From patchwork Thu Apr 11 21:53:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10896959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 633F21669 for ; Thu, 11 Apr 2019 21:53:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EDD628D1E for ; Thu, 11 Apr 2019 21:53:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4375828E3B; Thu, 11 Apr 2019 21:53:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E357F28D1E for ; Thu, 11 Apr 2019 21:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfDKVxs (ORCPT ); Thu, 11 Apr 2019 17:53:48 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:39380 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbfDKVxs (ORCPT ); Thu, 11 Apr 2019 17:53:48 -0400 Received: by mail-pf1-f193.google.com with SMTP id i17so4077951pfo.6 for ; Thu, 11 Apr 2019 14:53:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E4G6YUAgXImDBYdFj1sokm33D2oO9ehr2wvftnNOgNE=; b=HWz2p2WzAr9m9wrR5lO2+iVhyIO6Ie9eZDXgCjbTP9XYVNed3zG36ao8XZ53VS/HZH v9u6NCotcaLG21n6mSmIDDxtG0XgiDii55Xt8NRn4e6jimjNFEr33SG5QC/23+rLvQVu gqKXqU7jceL1iwb6CNFjy6IY9xJYKCRMLwQ63/e7TWNyFmvxzy7c3hzhWNRQfPHY4Q7e 5q7GnS0QxQsZ91/f2TYjj5RtaIJwqGuvnP1lx9S766Ph26TGomcmr69QJpo149e+7Sjf wk9nmZidEZB8sTG798rFYYe+qY0yg0O6kkhqDYKIzUpZb79JELWj4sbwaQm4HIsNPtfv sAmw== X-Gm-Message-State: APjAAAXw0Vo9Lv+W1+iTN7hmCZKsI2TS4Kit5bTaYDbc7ABGSzKtpHy+ Cae7F8Fp75Gt1apfn3xjEPU= X-Google-Smtp-Source: APXvYqzVOa4Eg/bbI14d6BkdqnzpxoA+DKVbciCiu/MbfnwLG3p3bkQEt4uMo8hPtSCo24FW4J5wiA== X-Received: by 2002:a62:4649:: with SMTP id t70mr52829994pfa.100.1555019627332; Thu, 11 Apr 2019 14:53:47 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id o67sm91651066pga.55.2019.04.11.14.53.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 14:53:46 -0700 (PDT) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Christoph Hellwig , Bart Van Assche , Himanshu Madhani , Giridhar Malavali Subject: [PATCH 08/10] qla2xxx: Remove qla_tgt_cmd.data_work and qla_tgt_cmd.data_work_free Date: Thu, 11 Apr 2019 14:53:23 -0700 Message-Id: <20190411215325.122837-9-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190411215325.122837-1-bvanassche@acm.org> References: <20190411215325.122837-1-bvanassche@acm.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'data_work' and 'data_work_free' member variables are set but never used. Hence remove both member variables. See also commit 6bcbb3174caa ("qla2xxx: Fix incorrect tcm_qla2xxx_free_cmd use during TMR ABORT (v2)"). Cc: Himanshu Madhani Cc: Giridhar Malavali Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.h | 2 -- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h index 37e342f12787..727dd52963c2 100644 --- a/drivers/scsi/qla2xxx/qla_target.h +++ b/drivers/scsi/qla2xxx/qla_target.h @@ -890,8 +890,6 @@ struct qla_tgt_cmd { unsigned int cmd_sent_to_fw:1; unsigned int cmd_in_wq:1; unsigned int aborted:1; - unsigned int data_work:1; - unsigned int data_work_free:1; unsigned int released:1; struct scatterlist *sg; /* cmd data buffer SG vector */ diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 55c107361a14..7f9d5461023a 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -500,9 +500,7 @@ static void tcm_qla2xxx_handle_data_work(struct work_struct *work) return; } - cmd->data_work = 1; if (cmd->aborted) { - cmd->data_work_free = 1; spin_unlock_irqrestore(&cmd->cmd_lock, flags); tcm_qla2xxx_free_cmd(cmd);