diff mbox series

[-next] scsi: lpfc: Make lpfc_sli4_oas_verify static

Message ID 20190417150554.34844-1-yuehaibing@huawei.com (mailing list archive)
State Mainlined
Commit c70929752511cb73dfb940d4c3f00e75ab55ef67
Headers show
Series [-next] scsi: lpfc: Make lpfc_sli4_oas_verify static | expand

Commit Message

Yue Haibing April 17, 2019, 3:05 p.m. UTC 
From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
 symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/scsi/lpfc/lpfc_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Smart April 18, 2019, 3:50 p.m. UTC | #1 
On 4/17/2019 8:05 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
>   symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/scsi/lpfc/lpfc_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 8e0de48..eaaef68 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -13087,7 +13087,7 @@ lpfc_io_resume(struct pci_dev *pdev)
>    * is destroyed.
>    *
>    **/
> -void
> +static void
>   lpfc_sli4_oas_verify(struct lpfc_hba *phba)
>   {
>   

Looks good. Interesting as there's a prototype for the function earlier 
which defines it as static.

Reviewed-by:  James Smart  <james.smart@broadcom.com>

-- james
Martin K. Petersen April 19, 2019, 12:37 a.m. UTC | #2 
Yue,

> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
>  symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?

Applied to 5.2/scsi-queue, thanks.
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 8e0de48..eaaef68 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -13087,7 +13087,7 @@  lpfc_io_resume(struct pci_dev *pdev)
  * is destroyed.
  *
  **/
-void
+static void
 lpfc_sli4_oas_verify(struct lpfc_hba *phba)
 {