From patchwork Thu Apr 18 10:40:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10906993 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4C901515 for ; Thu, 18 Apr 2019 10:44:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE01B28B91 for ; Thu, 18 Apr 2019 10:44:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B1DA628B9D; Thu, 18 Apr 2019 10:44:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 579C028B9C for ; Thu, 18 Apr 2019 10:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388583AbfDRKoj (ORCPT ); Thu, 18 Apr 2019 06:44:39 -0400 Received: from mail-eopbgr730077.outbound.protection.outlook.com ([40.107.73.77]:13696 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388304AbfDRKoi (ORCPT ); Thu, 18 Apr 2019 06:44:38 -0400 Received: from BYAPR07CA0006.namprd07.prod.outlook.com (2603:10b6:a02:bc::19) by BN8PR07MB6210.namprd07.prod.outlook.com (2603:10b6:408:b3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Thu, 18 Apr 2019 10:44:36 +0000 Received: from BY2NAM05FT027.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::209) by BYAPR07CA0006.outlook.office365.com (2603:10b6:a02:bc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.11 via Frontend Transport; Thu, 18 Apr 2019 10:44:35 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT027.mail.protection.outlook.com (10.152.100.164) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Thu, 18 Apr 2019 10:44:35 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Thu, 18 Apr 2019 03:40:13 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3IAeDou004876; Thu, 18 Apr 2019 03:40:13 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3IAeCsZ004875; Thu, 18 Apr 2019 03:40:12 -0700 From: Saurav Kashyap To: CC: , , , , Subject: [PATCH] Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO" Date: Thu, 18 Apr 2019 03:40:12 -0700 Message-ID: <20190418104012.4841-1-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132000578754708375;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(376002)(39860400002)(396003)(136003)(2980300002)(1110001)(339900001)(189003)(199004)(36756003)(26005)(47776003)(97736004)(2906002)(305945005)(336012)(126002)(476003)(2616005)(356004)(486006)(498600001)(76130400001)(26826003)(4744005)(14444005)(87636003)(1076003)(4326008)(36906005)(2351001)(81166006)(81156014)(86362001)(8936002)(8676002)(54906003)(316002)(51416003)(42186006)(16586007)(68736007)(53936002)(6862004)(85426001)(5660300002)(105606002)(107886003)(50466002)(48376002)(80596001)(69596002)(50226002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN8PR07MB6210;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb030c3b-408e-4d3a-52c1-08d6c3ead93e X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN8PR07MB6210; X-MS-TrafficTypeDiagnostic: BN8PR07MB6210: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0011612A55 X-Microsoft-Antispam-Message-Info: +aIR1C4d0owV/GlPfeL0Y65/ixq5xNr5OcyCGVwZ42JCgS74smvXKlXgkMXjwEL3SW0rZ1XUr4Rohpoy4Q0KZdFEoGczGs1lC+9X7Q2Gg2TU813LlE44RmmR9F+68Da5huvCpqCOzhO7GvSpZ4NNlT6IwtDm3/LVQQhqRfT3hNQSg88R8XXvAVBl10BF7Hmf3yqxD5irk+XvJXQ4so6msBXbNzn7wFWZf/L7UhYDxkzTQlWKyZV7NBqi53PlIftaEigI4eDaCQ0wn4BOpTnt9w7Te3AkyMUwAcYSY9CiodRqE1Txodq3bms/8YPFlBSJuMyZSXkKYihqvYCsdNhthOLxYYfwyUs5R0G07DTPEutSjmDReogbWfBmjerDX1bNhvj0H4MV+uNJAnQTonK2YqCGGxuCCUVlZ1w5ECqybsw= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2019 10:44:35.1465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb030c3b-408e-4d3a-52c1-08d6c3ead93e X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR07MB6210 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch clears FC_RP_STARTED flag during logoff, because of this re-login(flogi) didn't happen to the switch. This reverts commit 1550ec458e0cf1a40a170ab1f4c46e3f52860f65. Reviewed-by: Hannes Reinecke --- drivers/scsi/libfc/fc_rport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index dfba492..5bf6143 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -2162,7 +2162,6 @@ static void fc_rport_recv_logo_req(struct fc_lport *lport, struct fc_frame *fp) FC_RPORT_DBG(rdata, "Received LOGO request while in state %s\n", fc_rport_state(rdata)); - rdata->flags &= ~FC_RP_STARTED; fc_rport_enter_delete(rdata, RPORT_EV_STOP); mutex_unlock(&rdata->rp_mutex); kref_put(&rdata->kref, fc_rport_destroy);