From patchwork Mon Apr 22 05:45:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1BE8F1515 for ; Mon, 22 Apr 2019 05:45:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F22928668 for ; Mon, 22 Apr 2019 05:45:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 03D3E2866D; Mon, 22 Apr 2019 05:45:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B83628668 for ; Mon, 22 Apr 2019 05:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbfDVFpx (ORCPT ); Mon, 22 Apr 2019 01:45:53 -0400 Received: from mail-eopbgr740053.outbound.protection.outlook.com ([40.107.74.53]:65162 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpx (ORCPT ); Mon, 22 Apr 2019 01:45:53 -0400 Received: from DM6PR07CA0027.namprd07.prod.outlook.com (2603:10b6:5:94::40) by BN4PR07MB2161.namprd07.prod.outlook.com (2a01:111:e400:59c6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:50 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::202) by DM6PR07CA0027.outlook.office365.com (2603:10b6:5:94::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:50 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:50 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:36 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jaQ1003303; Sun, 21 Apr 2019 22:45:36 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5ja5E003302; Sun, 21 Apr 2019 22:45:36 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 11/12] qedf: Add return value to log message if scsi_add_host fails. Date: Sun, 21 Apr 2019 22:45:00 -0700 Message-ID: <20190422054501.3224-12-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855504134659;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(87636003)(26826003)(85426001)(498600001)(47776003)(2616005)(446003)(476003)(486006)(126002)(11346002)(86362001)(4326008)(5660300002)(69596002)(70206006)(80596001)(70586007)(6862004)(76130400001)(53936002)(305945005)(316002)(1076003)(16586007)(42186006)(4744005)(2351001)(8936002)(50466002)(54906003)(2906002)(8676002)(81166006)(81156014)(48376002)(36906005)(6666004)(76176011)(105606002)(51416003)(336012)(26005)(36756003)(50226002)(97736004)(68736007)(356004)(14444005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2161;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca4ca64b-04ed-42a4-03d3-08d6c6e5c6c5 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN4PR07MB2161; X-MS-TrafficTypeDiagnostic: BN4PR07MB2161: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: QmK5cvQ70upcQ4DwXDzdwcaV39U8VJKKsFxNbXZhdqh1rc7Mq9UmLTqzcHUsexG3oV+tK4BJpJv5M7Pvz2v+XW40MuCnoNS8S6tQEVwS5RrB+fyWminsKvOHW+t7a3LPRL9F/AdtsCHy2HKPb3jyQ0Rg1MK4BGYr++qziW8hQli2PtSUZ2sgQAay2uc5EmzAypyPtAdquYp8xtMgrNBWX1d5Wa7tdl1G4m5Tdg+pl1c/+dZiZ5vL3PoO4fps+qcZ+uUDpgldcbS6U/duaGIcwH54SAOABirto9zqER+U80WYH6+fpDqXkVh7Fld2tM6XHujxeWPenU5jj3Ze9jYgxnK3ZnHfKn/Nd32RzGbR746VWUhEsn2/ltTEkFj8M7IEglPJYPWmn32zy32M2NDCrFFFHjSQlMFKsDMYvK8B04w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:50.0731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca4ca64b-04ed-42a4-03d3-08d6c6e5c6c5 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2161 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Print return value of scsi_add_host on failure. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index ffe536e..5b07235 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -1763,7 +1763,8 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) rc = scsi_add_host(vn_port->host, &vport->dev); if (rc) { - QEDF_WARN(&(base_qedf->dbg_ctx), "Error adding Scsi_Host.\n"); + QEDF_WARN(&base_qedf->dbg_ctx, + "Error adding Scsi_Host rc=0x%x.\n", rc); goto err2; } @@ -3339,7 +3340,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) rc = scsi_add_host(host, &pdev->dev); if (rc) { QEDF_WARN(&qedf->dbg_ctx, - "Error adding Scsi_Host.\n"); + "Error adding Scsi_Host rc=0x%x.\n", rc); goto err6; } }