From patchwork Mon Apr 22 05:44:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CED371515 for ; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C167E28668 for ; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B616B2866D; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67D8128668 for ; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbfDVFpU (ORCPT ); Mon, 22 Apr 2019 01:45:20 -0400 Received: from mail-eopbgr700050.outbound.protection.outlook.com ([40.107.70.50]:15392 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpT (ORCPT ); Mon, 22 Apr 2019 01:45:19 -0400 Received: from SN4PR0701CA0019.namprd07.prod.outlook.com (2603:10b6:803:28::29) by MWHPR07MB2958.namprd07.prod.outlook.com (2603:10b6:300:1f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:17 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by SN4PR0701CA0019.outlook.office365.com (2603:10b6:803:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:17 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:16 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:11 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jBj8003271; Sun, 21 Apr 2019 22:45:11 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jB0r003270; Sun, 21 Apr 2019 22:45:11 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 03/12] qedf: Print scsi_cmd backpointer in good completion path if the command is still being used. Date: Sun, 21 Apr 2019 22:44:52 -0700 Message-ID: <20190422054501.3224-4-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855172121927;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(396003)(39860400002)(346002)(376002)(2980300002)(1110001)(339900001)(199004)(189003)(70206006)(305945005)(51416003)(76176011)(47776003)(126002)(476003)(2616005)(11346002)(446003)(26005)(87636003)(498600001)(486006)(336012)(36756003)(97736004)(70586007)(2351001)(85426001)(26826003)(5660300002)(69596002)(80596001)(316002)(36906005)(86362001)(2906002)(6862004)(1076003)(4326008)(356004)(48376002)(68736007)(50466002)(8936002)(8676002)(81166006)(81156014)(50226002)(53936002)(76130400001)(105606002)(42186006)(6666004)(16586007)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB2958;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31380f45-9e01-4fbb-e71d-08d6c6e5b2fa X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:MWHPR07MB2958; X-MS-TrafficTypeDiagnostic: MWHPR07MB2958: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: W2ZHKrsLU8ZpmEaZf3jLGMCJZjPA2B8ypmTt070x+e1NSi/BIT6jBwmtbP2uyFzA3586VG09wmzJU0Kpmihy3RQwpuf7dUcIwcK5XlFPsd04kjEgElFX/DJ7ivDyS46FWyQw6dBcCti5T2hxsDFRRsoK6MI6OksRTJG8BItv2PITZMvRPL4tFUtlYrReBXRJjqW2J13HOU+iR2yb8QAlk4ydcPbJqogBBJPkJ/mt9gnWJ1eEPKrI+3peX5vcce88paWvqXnr7K/pVXihE+r3JnYYA7Hpva7in56qp9ANXIXwPeIT4cUQTJAOInGtVDI6B11NSRGqxlaL4owVAwRpi4vRTnjPx+tzAU1ku75d0aNdnE5Bmxiv/dgJvJ+DM3bu0RgPpYKdd8mVOnl11hPQdXYdSGxCATrrFlYp/ELxubU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:16.8619 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31380f45-9e01-4fbb-e71d-08d6c6e5b2fa X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB2958 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - Printing scsi command pointer will help in crash dump analysis. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 51378e5..f2d4b30 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1859,9 +1859,9 @@ int qedf_initiate_abts(struct qedf_ioreq *io_req, bool return_scsi_cmd_on_abts) if (!test_bit(QEDF_CMD_OUTSTANDING, &io_req->flags) || test_bit(QEDF_CMD_IN_CLEANUP, &io_req->flags) || test_bit(QEDF_CMD_IN_ABORT, &io_req->flags)) { - QEDF_ERR(&(qedf->dbg_ctx), "io_req xid=0x%x already in " - "cleanup or abort processing or already " - "completed.\n", io_req->xid); + QEDF_ERR(&qedf->dbg_ctx, + "io_req xid=0x%x sc_cmd=%p already in cleanup or abort processing or already completed.\n", + io_req->xid, io_req->sc_cmd); rc = 1; goto drop_rdata_kref; }