From patchwork Mon Apr 22 05:44:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 308401515 for ; Mon, 22 Apr 2019 05:45:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23AD328668 for ; Mon, 22 Apr 2019 05:45:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 187862866D; Mon, 22 Apr 2019 05:45:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA50A28668 for ; Mon, 22 Apr 2019 05:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfDVFpY (ORCPT ); Mon, 22 Apr 2019 01:45:24 -0400 Received: from mail-eopbgr730042.outbound.protection.outlook.com ([40.107.73.42]:50144 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFpY (ORCPT ); Mon, 22 Apr 2019 01:45:24 -0400 Received: from SN4PR0701CA0019.namprd07.prod.outlook.com (2603:10b6:803:28::29) by BN4PR07MB2162.namprd07.prod.outlook.com (2a01:111:e400:59c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.11; Mon, 22 Apr 2019 05:45:21 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by SN4PR0701CA0019.outlook.office365.com (2603:10b6:803:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:21 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:21 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:14 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jEwD003275; Sun, 21 Apr 2019 22:45:14 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jEtT003274; Sun, 21 Apr 2019 22:45:14 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 04/12] qedf: Add LBA to underrun debug messages. Date: Sun, 21 Apr 2019 22:44:53 -0700 Message-ID: <20190422054501.3224-5-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855214095163;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(346002)(396003)(136003)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(36756003)(97736004)(336012)(47776003)(446003)(126002)(68736007)(498600001)(87636003)(26826003)(86362001)(50226002)(2616005)(476003)(11346002)(48376002)(50466002)(486006)(2351001)(26005)(51416003)(76176011)(4326008)(6862004)(105606002)(53936002)(54906003)(16586007)(70586007)(81156014)(81166006)(5660300002)(85426001)(36906005)(70206006)(76130400001)(316002)(80596001)(69596002)(305945005)(2906002)(8936002)(42186006)(1076003)(8676002)(356004)(6666004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2162;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6464f90-becc-4439-35f1-08d6c6e5b57b X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN4PR07MB2162; X-MS-TrafficTypeDiagnostic: BN4PR07MB2162: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: g9ixNofgCcGCOOgaEWHYbXLr8s0Kx3VKRTy4LUa5oFRMrdYwmuSVFbQN9Y+nsHQ/w30+Ih7T7vp7s0ZOu8khv7UO/pE1cQLe7UdIYLQYj5AoxzsJoL0dWlr5+lO5Ksr1bIhhZ6eUQ5GO2Y0aY4DTzJsRDJEjKGkfjSjBEEpAg1PlpCp7iXtQLQMLVLCADvyvfgS0/j/uKVQz0zYTRvbZLQYGmEDavRjwIbs6BvdgqTsKKVRY5y/UNCCf6TGFBYZCAxdOR5fLK01Ota6HOx5Af4L0sbIEe0BMbA1NLF4lf6iwy9LLvBph87HHs0ZCFQd601WkoUd6PIDB8DUZKYwdRfErsfoAGq59VPUzzUZAv/lJSL/NukKlpDcQVj5YNjYkqDPfA+3lfVJ9YZSJS4S5ZoYr2PdwDaFy1YfkyZvchxo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:21.0682 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6464f90-becc-4439-35f1-08d6c6e5b57b X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2162 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - Print LBA information for underrun cases. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index f2d4b30..29b456d 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1197,11 +1197,12 @@ void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, fw_residual_flag = GET_FIELD(cqe->cqe_info.rsp_info.fw_error_flags, FCOE_CQE_RSP_INFO_FW_UNDERRUN); if (fw_residual_flag) { - QEDF_ERR(&(qedf->dbg_ctx), - "Firmware detected underrun: xid=0x%x fcp_rsp.flags=0x%02x " - "fcp_resid=%d fw_residual=0x%x.\n", io_req->xid, - fcp_rsp->rsp_flags.flags, io_req->fcp_resid, - cqe->cqe_info.rsp_info.fw_residual); + QEDF_ERR(&qedf->dbg_ctx, + "Firmware detected underrun: xid=0x%x fcp_rsp.flags=0x%02x fcp_resid=%d fw_residual=0x%x lba=%02x%02x%02x%02x.\n", + io_req->xid, fcp_rsp->rsp_flags.flags, + io_req->fcp_resid, + cqe->cqe_info.rsp_info.fw_residual, sc_cmd->cmnd[2], + sc_cmd->cmnd[3], sc_cmd->cmnd[4], sc_cmd->cmnd[5]); if (io_req->cdb_status == 0) sc_cmd->result = (DID_ERROR << 16) | io_req->cdb_status;