diff mbox series

[v2,26/58] qla2xxx: Simplify a debug statement

Message ID	20190809030219.11296-27-bvanassche@acm.org (mailing list archive)
State	Mainlined
Commit	282d10565ee9b574c40b1233a7a666034e76aa4c
Headers	show Return-Path: <linux-scsi-owner@kernel.org> From: Bart Van Assche <bvanassche@acm.org> To: "Martin K . Petersen" <martin.petersen@oracle.com>, "James E . J . Bottomley" <jejb@linux.vnet.ibm.com> Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Himanshu Madhani <hmadhani@marvell.com> Subject: [PATCH v2 26/58] qla2xxx: Simplify a debug statement Date: Thu, 8 Aug 2019 20:01:47 -0700 Message-Id: <20190809030219.11296-27-bvanassche@acm.org> In-Reply-To: <20190809030219.11296-1-bvanassche@acm.org> References: <20190809030219.11296-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk
Series	qla2xxx patches for kernel v5.4 \| expand [v2,00/58] qla2xxx patches for kernel v5.4 [v2,01/58] qla2xxx: Make qla2x00_abort_srb() again decrease the sp reference count [v2,02/58] qla2xxx: Really fix qla2xxx_eh_abort() [v2,03/58] qla2xxx: Improve Linux kernel coding style conformance [v2,04/58] qla2xxx: Use tabs instead of spaces for indentation [v2,05/58] qla2xxx: Include the <asm/unaligned.h> header file from qla_dsd.h [v2,06/58] qla2xxx: Remove an include directive from qla_mr.c [v2,07/58] qla2xxx: Remove a superfluous forward declaration [v2,08/58] qla2xxx: Declare the fourth ql_dump_buffer() argument const [v2,09/58] qla2xxx: Change the return type of qla2x00_update_ms_fdmi_iocb() into void [v2,10/58] qla2xxx: Reduce the scope of three local variables in qla2xxx_queuecommand() [v2,11/58] qla2xxx: Declare qla_tgt_cmd.cdb const [v2,12/58] qla2xxx: Change data_dsd into an array [v2,13/58] qla2xxx: Verify locking assumptions at runtime [v2,14/58] qla2xxx: Reduce the number of casts in GID list code [v2,15/58] qla2xxx: Simplify qlt_lport_dump() [v2,16/58] qla2xxx: Remove a superfluous pointer check [v2,17/58] qla2xxx: Remove two superfluous tests [v2,18/58] qla2xxx: Simplify qla24xx_abort_sp_done() [v2,19/58] qla2xxx: Fix session lookup in qlt_abort_work() [v2,20/58] qla2xxx: Report the firmware status code if a mailbox command fails [v2,21/58] qla2xxx: Do not corrupt vha->plogi_ack_list [v2,22/58] qla2xxx: Use strlcpy() instead of strncpy() [v2,23/58] qla2xxx: Complain if a mailbox command times out [v2,24/58] qla2xxx: Complain if parsing the version string fails [v2,25/58] qla2xxx: Remove dead code [v2,26/58] qla2xxx: Simplify a debug statement [v2,27/58] qla2xxx: Fix qla24xx_process_bidir_cmd() [v2,28/58] qla2xxx: Remove unreachable code from qla83xx_idc_lock() [v2,29/58] qla2xxx: Suppress a Coveritiy complaint about integer overflow [v2,30/58] qla2xxx: Suppress multiple Coverity complaint about out-of-bounds accesses [v2,31/58] qla2xxx: Always check the qla2x00_wait_for_hba_online() return value [v2,32/58] qla2xxx: Declare fourth qla2x00_set_model_info() argument const [v2,33/58] qla2xxx: Complain if waiting for pending commands times out [v2,34/58] qla2xxx: Check the PCI info string output buffer size [v2,35/58] qla2xxx: Use memcpy() and strlcpy() instead of strcpy() and strncpy() [v2,36/58] qla2xxx: Complain if a soft reset fails [v2,37/58] qla2xxx: Introduce the be_id_t and le_id_t data types for FC src/dst IDs [v2,38/58] qla2xxx: Change the return type of qla24xx_read_flash_data() [v2,39/58] qla2xxx: Check secondary image if reading the primary image fails [v2,40/58] qla2xxx: Make it explicit that ELS pass-through IOCBs use little endian [v2,41/58] qla2xxx: Set the responder mode if appropriate for ELS pass-through IOCBs [v2,42/58] qla2xxx: Rework key encoding in qlt_find_host_by_d_id() [v2,43/58] qla2xxx: Enable type checking for the SRB free and done callback functions [v2,44/58] qla2xxx: Introduce the function qla2xxx_init_sp() [v2,45/58] qla2xxx: Fix a race condition between aborting and completing a SCSI command [v2,46/58] qla2xxx: Make qlt_handle_abts_completion() more robust [v2,47/58] qla2xxx: Modify NVMe include directives [v2,48/58] qla2xxx: Introduce qla2xxx_get_next_handle() [v2,49/58] qla2xxx: Make sure that aborted commands are freed [v2,50/58] qla2xxx: Complain if sp->done() is not called from the completion path [v2,51/58] qla2xxx: Let the compiler check the type of the SCSI command context pointer [v2,52/58] qla2xxx: Remove superfluous sts_entry_* casts [v2,53/58] qla2xxx: Report invalid mailbox status codes [v2,54/58] qla2xxx: Inline the qla2x00_fcport_event_handler() function [v2,55/58] qla2xxx: Introduce qla2x00_els_dcmd2_free() [v2,56/58] qla2xxx: Remove two superfluous if-tests [v2,57/58] qla2xxx: Simplify qla24xx_async_abort_cmd() [v2,58/58] qla2xxx: Fix a NULL pointer dereference

Commit Message

Bart Van Assche Aug. 9, 2019, 3:01 a.m. UTC

Read the FC port state once instead of twice. This patch fixes the
following Coverity complaint:

Unchecked return value (CHECKED_RETURN)
check_return: Calling atomic_read without checking return value (as is
done elsewhere 80 out of 92 times).

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/qla2xxx/qla_isr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index e8ce57cb897e..55eb51539cb0 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2726,7 +2726,7 @@  qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
 				"Port to be marked lost on fcport=%02x%02x%02x, current "
 				"port state= %s comp_status %x.\n", fcport->d_id.b.domain,
 				fcport->d_id.b.area, fcport->d_id.b.al_pa,
-				port_state_str[atomic_read(&fcport->state)],
+				port_state_str[FCS_ONLINE],
 				comp_status);
 
 			qla2x00_mark_device_lost(fcport->vha, fcport, 1, 1);