| Message ID | 20190927073031.62296-1-dwagner@suse.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9bc6157f5fd0e898c94f3018d088a3419bde0d8f |
| Headers | show |
| Series | [v2] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() | expand |
Daniel, > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuations element. According to the firmware documentation > it is possible that multiple status continuations are emitted by the > firmware. Applied to 5.4/scsi-fixes. Thanks!
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 30fd2d355f3a..acef3d73983c 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -2858,8 +2858,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) if (sense_len == 0) { rsp->status_srb = NULL; sp->done(sp, cp->result); - } else { - WARN_ON_ONCE(true); } }
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware. Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") Cc: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Daniel Wagner <dwagner@suse.de> Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> --- changes v2: - add Fixes and Reviewed-by tags drivers/scsi/qla2xxx/qla_isr.c | 2 -- 1 file changed, 2 deletions(-)