diff mbox series

[SCSI] esas2r: unlock on error in esas2r_nvram_read_direct()

Message ID 20191022102324.GA27540@mwanda (mailing list archive)
State Mainlined
Commit 906ca6353ac09696c1bf0892513c8edffff5e0a6
Headers show
Series [SCSI] esas2r: unlock on error in esas2r_nvram_read_direct() | expand

Commit Message

Dan Carpenter Oct. 22, 2019, 10:23 a.m. UTC 
This error path is missing an unlock.

Fixes: 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/esas2r/esas2r_flash.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin K. Petersen Oct. 25, 2019, 1:17 a.m. UTC | #1 
Dan,

> This error path is missing an unlock.

Applied to 5.5/scsi-queue, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/esas2r/esas2r_flash.c b/drivers/scsi/esas2r/esas2r_flash.c
index 7bd376d95ed5..b02ac389e6c6 100644
--- a/drivers/scsi/esas2r/esas2r_flash.c
+++ b/drivers/scsi/esas2r/esas2r_flash.c
@@ -1197,6 +1197,7 @@  bool esas2r_nvram_read_direct(struct esas2r_adapter *a)
 	if (!esas2r_read_flash_block(a, a->nvram, FLS_OFFSET_NVR,
 				     sizeof(struct esas2r_sas_nvram))) {
 		esas2r_hdebug("NVRAM read failed, using defaults");
+		up(&a->nvram_semaphore);
 		return false;
 	}