| Message ID | 20191104090151.129140-15-hare@suse.de (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | Revamp SCSI result values | expand |
On 11/4/19 1:01 AM, Hannes Reinecke wrote: > Use standard SAM status codes and omit the explicit shift to convert > from linux-specific ones. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > drivers/scsi/pcmcia/nsp_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c > index 97416e1dcc5b..8e905fb94fd3 100644 > --- a/drivers/scsi/pcmcia/nsp_cs.c > +++ b/drivers/scsi/pcmcia/nsp_cs.c > @@ -223,7 +223,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt, > > data->CurrentSC = SCpnt; > > - SCpnt->SCp.Status = CHECK_CONDITION; > + SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION; > SCpnt->SCp.Message = 0; > SCpnt->SCp.have_data_in = IO_UNKNOWN; > SCpnt->SCp.sent_command = 0; It seems like there is a mismatch between the patch description and the patch. The patch description refers to omitting an explicit shift but I don't see that omission in the patch itself? Bart.
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index 97416e1dcc5b..8e905fb94fd3 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c @@ -223,7 +223,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt, data->CurrentSC = SCpnt; - SCpnt->SCp.Status = CHECK_CONDITION; + SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION; SCpnt->SCp.Message = 0; SCpnt->SCp.have_data_in = IO_UNKNOWN; SCpnt->SCp.sent_command = 0;
Use standard SAM status codes and omit the explicit shift to convert from linux-specific ones. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/pcmcia/nsp_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)