diff mbox series

[05/52] libata-scsi: use standard SAM status codes

Message ID	20191104090151.129140-6-hare@suse.de (mailing list archive)
State	Deferred
Headers	show Return-Path: <SRS0=MVi0=Y4=vger.kernel.org=linux-scsi-owner@kernel.org> From: Hannes Reinecke <hare@suse.de> To: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Christoph Hellwig <hch@lst.de>, Bart van Assche <bvanassche@acm.org>, James Bottomley <james.bottomley@hansenpartnership.com>, linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCH 05/52] libata-scsi: use standard SAM status codes Date: Mon, 4 Nov 2019 10:01:04 +0100 Message-Id: <20191104090151.129140-6-hare@suse.de> In-Reply-To: <20191104090151.129140-1-hare@suse.de> References: <20191104090151.129140-1-hare@suse.de> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk
Series	Revamp SCSI result values \| expand [PATCHv3,00/52] Revamp SCSI result values [01/52] aic7xxx,aic79xxx: remove driver-defined SAM status definitions [02/52] bfa: drop driver-defined SCSI status codes [03/52] wd33c93: use SCSI status [04/52] acornscsi: use standard defines [05/52] libata-scsi: use standard SAM status codes [06/52] ib_srp: use standard SAM status codes [07/52] 3w-xxxx: use standard SAM status codes [08/52] arcmsr: use standard SAM status codes [09/52] dc395x: use standard SAM status codes [10/52] megaraid: use standard SAM status codes [11/52] megaraid_mboxi: use standard SAM status codes [12/52] gdth: use standard SAM status codes [13/52] dpt_i2o: use standard SAM status codes [14/52] nsp_cs: use standard SAM status codes [15/52] nsp32: fixup status handling [16/52] dc395: drop private SAM status code definitions [17/52] qla4xxx: use standard SAM status definitions [18/52] scsi: change status_byte() to return the standard SCSI status [19/52] target_core: Fixup target_complete_cmd() usage [20/52] sg: use SAM status definitions and avoid using masked_status [21/52] initio: use standard SAM status definitions [22/52] scsi: Kill obsolete linux-specific status codes [23/52] scsi: introduce set_status_byte() [24/52] advansys: kill driver_defined status byte accessors [25/52] scsi: introduce scsi_build_sense() [26/52] libata-scsi: use scsi_build_sense() [27/52] zfcp: use scsi_build_sense() [28/52] 3w-xxxx: use scsi_build_sense() [29/52] libiscsi: use scsi_build_sense() [30/52] lpfc: use scsi_build_sense() [31/52] mpt3sas: use scsi_build_sense() [32/52] mvumi: use scsi_build_sense() [33/52] myrb: use scsi_build_sense() [34/52] myrs: use scsi_build_sense() [35/52] ps3rom: use scsi_build_sense() [36/52] qla2xxx: use scsi_build_sense() [37/52] scsi_debug: use scsi_build_sense() [38/52] smartpqi: use scsi_build_sense() [39/52] stex: use scsi_build_sense() [40/52] scsi: Kill DRIVER_SENSE [41/52] scsi: Kill DRIVER_HARD [42/52] scsi_error: use DID_TIME_OUT instead of DRIVER_TIMEOUT [43/52] scsi: Kill DRIVER_TIMEOUT [44/52] scsi: do not use DRIVER_INVALID [45/52] st: return error code in st_scsi_execute() [46/52] scsi_ioctl: return error code when blk_rq_map_kern() fails [47/52] scsi_dh_alua: do not interpret DRIVER_ERROR [48/52] 3w-9xxx: Kill unreachable code in twa_interrupt() [49/52] xen-scsiback: stop using DRIVER_ERROR [50/52] scsi: stop using DRIVER_ERROR [51/52] scsi: Kill DRIVER_MEDIA, DRIVER_SOFT, and DRIVER_BUSY [52/52] scsi: Drop the now obsolete driver_byte definitions

Commit Message

Hannes Reinecke Nov. 4, 2019, 9:01 a.m. UTC

Use standard SAM status codes and omit the explicit shift to convert
from linux-specific ones.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/ata/libata-scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bart Van Assche Nov. 4, 2019, 5:36 p.m. UTC | #1

On 11/4/19 1:01 AM, Hannes Reinecke wrote:
> Use standard SAM status codes and omit the explicit shift to convert
> from linux-specific ones.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

diff mbox series

Patch

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 76d0f9de767b..b197d2fbe3f8 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -856,7 +856,7 @@  static struct ata_queued_cmd *ata_scsi_qc_new(struct ata_device *dev,
 		if (cmd->request->rq_flags & RQF_QUIET)
 			qc->flags |= ATA_QCFLAG_QUIET;
 	} else {
-		cmd->result = (DID_OK << 16) | (QUEUE_FULL << 1);
+		cmd->result = (DID_OK << 16) | SAM_STAT_TASK_SET_FULL;
 		cmd->scsi_done(cmd);
 	}