| Message ID | 20200107014956.41748-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fdb827e4a3f84cb92e286a821114ac0ad79c8281 |
| Headers | show |
| Series | [-next] scsi: lpfc: Make lpfc_defer_acc_rsp static | expand |
On 1/6/2020 5:49 PM, YueHaibing wrote: > Fix sparse warning: > > drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning: > symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c > index 1c46e3a..a024e5a 100644 > --- a/drivers/scsi/lpfc/lpfc_nportdisc.c > +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c > @@ -340,7 +340,7 @@ lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox) > * This routine is only called if we are SLI4, acting in target > * mode and the remote NPort issues the PLOGI after link up. > **/ > -void > +static void > lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) > { > struct lpfc_vport *vport = pmb->vport; Yep. Looks good. Thank You Reviewed-by: James Smart <james.smart@broadcom.com> -- james
YueHaibing, > Fix sparse warning: > > drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning: > symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static? Applied to 5.6/scsi-queue, thanks!
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c index 1c46e3a..a024e5a 100644 --- a/drivers/scsi/lpfc/lpfc_nportdisc.c +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c @@ -340,7 +340,7 @@ lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox) * This routine is only called if we are SLI4, acting in target * mode and the remote NPort issues the PLOGI after link up. **/ -void +static void lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) { struct lpfc_vport *vport = pmb->vport;
Fix sparse warning: drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning: symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)