From patchwork Sun Mar 15 09:42:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 11438789 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C35F92A for ; Sun, 15 Mar 2020 09:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA41E206E9 for ; Sun, 15 Mar 2020 09:42:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbgCOJmw (ORCPT ); Sun, 15 Mar 2020 05:42:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:58190 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728133AbgCOJmw (ORCPT ); Sun, 15 Mar 2020 05:42:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1504EACB5; Sun, 15 Mar 2020 09:42:47 +0000 (UTC) From: Takashi Iwai To: linux-scsi@vger.kernel.org Cc: "James E . J . Bottomley" , "Martin K . Petersen" , Achim Leubner Subject: [PATCH v2 4/8] scsi: gdth: Use scnprintf() for avoiding potential buffer overflow Date: Sun, 15 Mar 2020 10:42:37 +0100 Message-Id: <20200315094241.9086-5-tiwai@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200315094241.9086-1-tiwai@suse.de> References: <20200315094241.9086-1-tiwai@suse.de> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Cc: "James E . J . Bottomley" Cc: "Martin K . Petersen" Cc: Achim Leubner Cc: linux-scsi@vger.kernel.org Signed-off-by: Takashi Iwai --- v1->v2: no change drivers/scsi/gdth_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/gdth_proc.c b/drivers/scsi/gdth_proc.c index 381d849726ac..34149842cf1c 100644 --- a/drivers/scsi/gdth_proc.c +++ b/drivers/scsi/gdth_proc.c @@ -193,7 +193,7 @@ int gdth_show_info(struct seq_file *m, struct Scsi_Host *host) for (i = 1; i < MAX_RES_ARGS; i++) { if (reserve_list[i] == 0xff) break; - hlen += snprintf(hrec + hlen , 161 - hlen, ",%d", reserve_list[i]); + hlen += scnprintf(hrec + hlen , 161 - hlen, ",%d", reserve_list[i]); } } seq_printf(m,