| Message ID | 20200402085812.32948-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1d95b8a2d41f0cfbf3cefb5d986941bde2e1378f |
| Headers | show |
| Series | [v2] scsi: hisi_sas: Fix build error without SATA_HOST | expand |
On 4/2/20 10:58 AM, YueHaibing wrote: > If SATA_HOST is n, build fails: > > drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd': > hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis' > > Select SATA_HOST to fix this. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: bd322af15ce9 ("ata: make SATA_PMP option selectable only if any SATA host driver is enabled") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> PS I have audited all drivers dependent on ATA again and this is the only driver needing fixing. > --- > v2: use correct Fixes tag > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index 90a17452a50d..13ed9073fc72 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -6,6 +6,7 @@ config SCSI_HISI_SAS > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > depends on ATA > + select SATA_HOST > help > This driver supports HiSilicon's SAS HBA, including support based > on platform device > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On 02/04/2020 09:58, YueHaibing wrote: > If SATA_HOST is n, build fails: > > drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd': > hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis' > > Select SATA_HOST to fix this. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: bd322af15ce9 ("ata: make SATA_PMP option selectable only if any SATA host driver is enabled") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: John Garry <john.garry@huawei.com> > --- > v2: use correct Fixes tag > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index 90a17452a50d..13ed9073fc72 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -6,6 +6,7 @@ config SCSI_HISI_SAS > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > depends on ATA > + select SATA_HOST > help > This driver supports HiSilicon's SAS HBA, including support based > on platform device >
Yue Haibing, > If SATA_HOST is n, build fails: > > drivers/scsi/hisi_sas/hisi_sas_main.o: In function > `hisi_sas_fill_ata_reset_cmd': hisi_sas_main.c:(.text+0x2500): > undefined reference to `ata_tf_to_fis' > > Select SATA_HOST to fix this. Applied to 5.7/scsi-fixes. Thanks!
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig index 90a17452a50d..13ed9073fc72 100644 --- a/drivers/scsi/hisi_sas/Kconfig +++ b/drivers/scsi/hisi_sas/Kconfig @@ -6,6 +6,7 @@ config SCSI_HISI_SAS select SCSI_SAS_LIBSAS select BLK_DEV_INTEGRITY depends on ATA + select SATA_HOST help This driver supports HiSilicon's SAS HBA, including support based on platform device
If SATA_HOST is n, build fails: drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd': hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis' Select SATA_HOST to fix this. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: bd322af15ce9 ("ata: make SATA_PMP option selectable only if any SATA host driver is enabled") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: use correct Fixes tag --- drivers/scsi/hisi_sas/Kconfig | 1 + 1 file changed, 1 insertion(+)