| Message ID | 20200409084910.44336-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5d296cc9ab6e5cafaef2f81e1376320a6b6de50b |
| Headers | show |
| Series | scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static | expand |
Jason, > Fix the following sparse warning: > > drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex' > was not declared. Should it be static? > drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not > declared. Should it be static? Applied to 5.8/scsi-queue, thanks!
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 3337cd341d21..441a45349349 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -526,7 +526,7 @@ static struct pci_device_id qla1280_pci_tbl[] = { }; MODULE_DEVICE_TABLE(pci, qla1280_pci_tbl); -DEFINE_MUTEX(qla1280_firmware_mutex); +static DEFINE_MUTEX(qla1280_firmware_mutex); struct qla_fw { char *fwname; @@ -535,7 +535,7 @@ struct qla_fw { #define QL_NUM_FW_IMAGES 3 -struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = { +static struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = { {"qlogic/1040.bin", NULL}, /* image 0 */ {"qlogic/1280.bin", NULL}, /* image 1 */ {"qlogic/12160.bin", NULL}, /* image 2 */
Fix the following sparse warning: drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex' was not declared. Should it be static? drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/qla1280.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)