| Message ID | 20200411001933.10072-8-jbi.octave@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | None | expand |
Jules, > Sparse reports a warning at bnx2fc_abts_cleanup() > > warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock > > The root cause is the missing annotation at bnx2fc_abts_cleanup() > > Add the missing __must_hold(&tgt->tgt_lock) annotation Applied to 5.8/scsi-queue, thanks!
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 4c8122a82322..b45f40db9379 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_io.c +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c @@ -1081,6 +1081,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) } static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) + __must_hold(&tgt->tgt_lock) { struct bnx2fc_rport *tgt = io_req->tgt; unsigned int time_left;
Sparse reports a warning at bnx2fc_abts_cleanup() warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock The root cause is the missing annotation at bnx2fc_abts_cleanup() Add the missing __must_hold(&tgt->tgt_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 1 + 1 file changed, 1 insertion(+)