@@ -3662,8 +3662,7 @@ ahd_free_tstate(struct ahd_softc *ahd, u_int scsi_id, char channel, int force)
return;
tstate = ahd->enabled_targets[scsi_id];
- if (tstate != NULL)
- kfree(tstate);
+ kfree(tstate);
ahd->enabled_targets[scsi_id] = NULL;
}
#endif
@@ -6120,8 +6119,7 @@ ahd_set_unit(struct ahd_softc *ahd, int unit)
void
ahd_set_name(struct ahd_softc *ahd, char *name)
{
- if (ahd->name != NULL)
- kfree(ahd->name);
+ kfree(ahd->name);
ahd->name = name;
}
@@ -6182,12 +6180,9 @@ ahd_free(struct ahd_softc *ahd)
kfree(ahd->black_hole);
}
#endif
- if (ahd->name != NULL)
- kfree(ahd->name);
- if (ahd->seep_config != NULL)
- kfree(ahd->seep_config);
- if (ahd->saved_stack != NULL)
- kfree(ahd->saved_stack);
+ kfree(ahd->name);
+ kfree(ahd->seep_config);
+ kfree(ahd->saved_stack);
kfree(ahd);
return;
}
Fix the following coccicheck warning: drivers/scsi/aic7xxx/aic79xx_core.c:6186:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/aic7xxx/aic79xx_core.c:6188:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/aic7xxx/aic79xx_core.c:6190:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/aic7xxx/aic79xx_core.c:3666:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/aic7xxx/aic79xx_core.c:6124:2-7: WARNING: NULL check before some freeing functions is not needed. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/aic7xxx/aic79xx_core.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)