diff mbox series

[v2,2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close

Message ID 20200424035843.5914-3-houpu@bytedance.com (mailing list archive)
State Superseded
Headers show
Series iscsi-target: fix login error when receiving is too fast | expand

Commit Message

Hou Pu April 24, 2020, 3:58 a.m. UTC 
Following commit changed the return value of __iscsi_target_sk_check_close.
But the pr_debug is still printing FALSE when returing TRUE which is a little
confusing.

commit 25cdda95fda78d22d44157da15aa7ea34be3c804
Author: Nicholas Bellinger <nab@linux-iscsi.org>
Date:   Wed May 24 21:47:09 2017 -0700

    iscsi-target: Fix initial login PDU asynchronous socket close OOPs

Signed-off-by: Hou Pu <houpu@bytedance.com>
---
 drivers/target/iscsi/iscsi_target_nego.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaitanya Kulkarni April 24, 2020, 4:16 a.m. UTC | #1 
Ho

On 04/23/2020 08:59 PM, Hou Pu wrote:
> commit 25cdda95fda78d22d44157da15aa7ea34be3c804
> Author: Nicholas Bellinger<nab@linux-iscsi.org>
> Date:   Wed May 24 21:47:09 2017 -0700
>
>      iscsi-target: Fix initial login PDU asynchronous socket close OOPs

Thanks for the patch.

Did you get a chance to run checkpatch.pl on this patch ?
Hou Pu April 24, 2020, 5:25 a.m. UTC | #2 
On Fri, Apr 24, 2020 at 12:16 PM Chaitanya Kulkarni
<Chaitanya.Kulkarni@wdc.com> wrote:
>
> Ho
>
> On 04/23/2020 08:59 PM, Hou Pu wrote:
> > commit 25cdda95fda78d22d44157da15aa7ea34be3c804
> > Author: Nicholas Bellinger<nab@linux-iscsi.org>
> > Date:   Wed May 24 21:47:09 2017 -0700
> >
> >      iscsi-target: Fix initial login PDU asynchronous socket close OOPs
>
> Thanks for the patch.
>
> Did you get a chance to run checkpatch.pl on this patch ?

Will fix it. Sorry for the stupid format error.

Thanks,
Hou
diff mbox series

Patch

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 5292b6c51b4e..2fee1946fb7a 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -481,7 +481,7 @@  static bool __iscsi_target_sk_check_close(struct sock *sk)
 {
 	if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) {
 		pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE,"
-			"returning FALSE\n");
+			"returning TRUE\n");
 		return true;
 	}
 	return false;