| Message ID | 20200427030310.19687-6-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix qla2xxx endianness annotations | expand |
On Sun, Apr 26, 2020 at 08:03:04PM -0700, Bart Van Assche wrote: > This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386. > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Cc: Quinn Tran <qutran@marvell.com> > Cc: Martin Wilck <mwilck@suse.com> > Cc: Daniel Wagner <dwagner@suse.de> > Cc: Roman Bolshakov <r.bolshakov@yadro.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Daniel Wagner <dwagner@suse.de>
On 4/26/20 10:03 PM, Bart Van Assche wrote: > This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386. > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Cc: Quinn Tran <qutran@marvell.com> > Cc: Martin Wilck <mwilck@suse.com> > Cc: Daniel Wagner <dwagner@suse.de> > Cc: Roman Bolshakov <r.bolshakov@yadro.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/qla2xxx/qla_dbg.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h > index 433e95502808..b106b6808d34 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.h > +++ b/drivers/scsi/qla2xxx/qla_dbg.h > @@ -238,6 +238,7 @@ struct qla2xxx_offld_chain { > uint32_t chain_size; > > uint32_t size; > + uint32_t reserved; > u64 addr; > }; > > I think this should to be verified with Marvell Firmware folks. (I don't have API document handy with me anymore)
On 2020-04-27 07:27, himanshu.madhani@oracle.com wrote: > On 4/26/20 10:03 PM, Bart Van Assche wrote: >> This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386. >> >> Cc: Nilesh Javali <njavali@marvell.com> >> Cc: Himanshu Madhani <himanshu.madhani@oracle.com> >> Cc: Quinn Tran <qutran@marvell.com> >> Cc: Martin Wilck <mwilck@suse.com> >> Cc: Daniel Wagner <dwagner@suse.de> >> Cc: Roman Bolshakov <r.bolshakov@yadro.com> >> Signed-off-by: Bart Van Assche <bvanassche@acm.org> >> --- >> drivers/scsi/qla2xxx/qla_dbg.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/qla2xxx/qla_dbg.h >> b/drivers/scsi/qla2xxx/qla_dbg.h >> index 433e95502808..b106b6808d34 100644 >> --- a/drivers/scsi/qla2xxx/qla_dbg.h >> +++ b/drivers/scsi/qla2xxx/qla_dbg.h >> @@ -238,6 +238,7 @@ struct qla2xxx_offld_chain { >> uint32_t chain_size; >> uint32_t size; >> + uint32_t reserved; >> u64 addr; >> }; >> > > I think this should to be verified with Marvell Firmware folks. (I don't > have API document handy with me anymore) Please note that this patch does not change the layout of this structure for x86_64. All this patch does is to make a hole in this structure explicit. Bart.
On 4/27/20 5:03 AM, Bart Van Assche wrote: > This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386. > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Cc: Quinn Tran <qutran@marvell.com> > Cc: Martin Wilck <mwilck@suse.com> > Cc: Daniel Wagner <dwagner@suse.de> > Cc: Roman Bolshakov <r.bolshakov@yadro.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/qla2xxx/qla_dbg.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h > index 433e95502808..b106b6808d34 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.h > +++ b/drivers/scsi/qla2xxx/qla_dbg.h > @@ -238,6 +238,7 @@ struct qla2xxx_offld_chain { > uint32_t chain_size; > > uint32_t size; > + uint32_t reserved; > u64 addr; > }; > > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
On Sun, 26 Apr 2020, 8:03pm, Bart Van Assche wrote: > This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386. > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Cc: Quinn Tran <qutran@marvell.com> > Cc: Martin Wilck <mwilck@suse.com> > Cc: Daniel Wagner <dwagner@suse.de> > Cc: Roman Bolshakov <r.bolshakov@yadro.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/qla2xxx/qla_dbg.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h > index 433e95502808..b106b6808d34 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.h > +++ b/drivers/scsi/qla2xxx/qla_dbg.h > @@ -238,6 +238,7 @@ struct qla2xxx_offld_chain { > uint32_t chain_size; > > uint32_t size; > + uint32_t reserved; > u64 addr; > }; > > Reviewed-by: Arun Easi <aeasi@marvell.com>
diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h index 433e95502808..b106b6808d34 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.h +++ b/drivers/scsi/qla2xxx/qla_dbg.h @@ -238,6 +238,7 @@ struct qla2xxx_offld_chain { uint32_t chain_size; uint32_t size; + uint32_t reserved; u64 addr; };
This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386. Cc: Nilesh Javali <njavali@marvell.com> Cc: Himanshu Madhani <himanshu.madhani@oracle.com> Cc: Quinn Tran <qutran@marvell.com> Cc: Martin Wilck <mwilck@suse.com> Cc: Daniel Wagner <dwagner@suse.de> Cc: Roman Bolshakov <r.bolshakov@yadro.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/qla2xxx/qla_dbg.h | 1 + 1 file changed, 1 insertion(+)