diff mbox series

scsi: ufs: Bump supported UFS HCI version to 3.0

Message ID 20200604063559.18080-1-manivannan.sadhasivam@linaro.org (mailing list archive)
State Rejected
Headers show
Series scsi: ufs: Bump supported UFS HCI version to 3.0 | expand

Commit Message

Manivannan Sadhasivam June 4, 2020, 6:35 a.m. UTC
UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
adding it to the list of supported versions.

I don't have the exact information of the additional registers supported
in version 3.0. Hence the change just adds 0x300 to the list of supported
versions to remove the below warning:

"ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/scsi/ufs/ufshci.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin K. Petersen June 10, 2020, 2:25 a.m. UTC | #1
Avri: Please review!

> UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> adding it to the list of supported versions.
>
> I don't have the exact information of the additional registers supported
> in version 3.0. Hence the change just adds 0x300 to the list of supported
> versions to remove the below warning:
>
> "ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  drivers/scsi/ufs/ufshci.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> index c2961d37cc1c..f2ee81669b00 100644
> --- a/drivers/scsi/ufs/ufshci.h
> +++ b/drivers/scsi/ufs/ufshci.h
> @@ -104,6 +104,7 @@ enum {
>  	UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
>  	UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
>  	UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
> +	UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
>  };
>  
>  /*
Alim Akhtar June 10, 2020, 3:35 a.m. UTC | #2
HI Manivannan

On Thu, Jun 4, 2020 at 12:08 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> adding it to the list of supported versions.
>
> I don't have the exact information of the additional registers supported
> in version 3.0. Hence the change just adds 0x300 to the list of supported
> versions to remove the below warning:
>
> "ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  drivers/scsi/ufs/ufshci.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> index c2961d37cc1c..f2ee81669b00 100644
> --- a/drivers/scsi/ufs/ufshci.h
> +++ b/drivers/scsi/ufs/ufshci.h
> @@ -104,6 +104,7 @@ enum {
>         UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
>         UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
>         UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
> +       UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */

See the current discussion on this https://lkml.org/lkml/2020/4/27/192

>  };
>
>  /*
> --
> 2.17.1
>
Avri Altman June 10, 2020, 7:34 a.m. UTC | #3
> 
> Avri: Please review!
> 
> > UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> > adding it to the list of supported versions.
> >
> > I don't have the exact information of the additional registers supported
> > in version 3.0. Hence the change just adds 0x300 to the list of supported
> > versions to remove the below warning:
> >
> > "ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
> >
> > Signed-off-by: Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org>
Already Nacked by Christoph.
Thanks,
Avri

> > ---
> >  drivers/scsi/ufs/ufshci.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> > index c2961d37cc1c..f2ee81669b00 100644
> > --- a/drivers/scsi/ufs/ufshci.h
> > +++ b/drivers/scsi/ufs/ufshci.h
> > @@ -104,6 +104,7 @@ enum {
> >       UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
> >       UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
> >       UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
> > +     UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
> >  };
> >
> >  /*
> 
> --
> Martin K. Petersen      Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index c2961d37cc1c..f2ee81669b00 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -104,6 +104,7 @@  enum {
 	UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
 	UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
 	UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
+	UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
 };
 
 /*