From patchwork Mon Jun 15 14:48:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 11605261 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B23C618 for ; Mon, 15 Jun 2020 14:48:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E39BE207DA for ; Mon, 15 Jun 2020 14:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QaoxgXDr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730766AbgFOOsO (ORCPT ); Mon, 15 Jun 2020 10:48:14 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:24386 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730353AbgFOOsN (ORCPT ); Mon, 15 Jun 2020 10:48:13 -0400 X-UUID: 0c4e5100b1c744faa74deee3bcffb86d-20200615 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=9Jrxg+K/KEKim/cVYfaklTsm5g5BtXdZJCkdT9NVb7Y=; b=QaoxgXDrbPxiv114paz3+Qxoy8lZADTKf6A+w9sShjDSX8lGpPvZoTs6crJ8qhrrwygSRKBBHrs2pX01Q4Wxjt7bZJ/J1HPUvmBM6OfX1IB/6FxP/pCrgxZYswNkjOuvyNKiJ+2B7hkWKzjgryMQFznjORlroOBDSN5qXg+5XN4=; X-UUID: 0c4e5100b1c744faa74deee3bcffb86d-20200615 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1823175320; Mon, 15 Jun 2020 22:48:08 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Jun 2020 22:48:04 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 15 Jun 2020 22:48:03 +0800 From: Stanley Chu To: , , , , , CC: , , , , , , , , , , , , , Stanley Chu Subject: [PATCH v2 3/3] scsi: ufs-mediatek: Print host information for failed supsend and resume Date: Mon, 15 Jun 2020 22:48:05 +0800 Message-ID: <20200615144805.6921-4-stanley.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200615144805.6921-1-stanley.chu@mediatek.com> References: <20200615144805.6921-1-stanley.chu@mediatek.com> MIME-Version: 1.0 X-MTK: N Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Print host state and register dumps while suspend or resume flow is failed. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufs-mediatek.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index d56ce8d97d4e..0bb7ed841809 100644 --- a/drivers/scsi/ufs/ufs-mediatek.c +++ b/drivers/scsi/ufs/ufs-mediatek.c @@ -469,23 +469,24 @@ static int ufs_mtk_link_set_hpm(struct ufs_hba *hba) err = ufshcd_hba_enable(hba); if (err) - return err; + goto out; err = ufs_mtk_unipro_set_pm(hba, 0); if (err) - return err; + goto out; err = ufshcd_uic_hibern8_exit(hba); if (!err) ufshcd_set_link_active(hba); else - return err; + goto out; err = ufshcd_make_hba_operational(hba); +out: if (err) - return err; - - return 0; + ufshcd_print_info(hba, UFS_INFO_HOST_STATE | + UFS_INFO_HOST_REGS | UFS_INFO_PWR); + return err; } static int ufs_mtk_link_set_lpm(struct ufs_hba *hba) @@ -494,6 +495,9 @@ static int ufs_mtk_link_set_lpm(struct ufs_hba *hba) err = ufs_mtk_unipro_set_pm(hba, 1); if (err) { + ufshcd_print_info(hba, UFS_INFO_HOST_STATE | + UFS_INFO_HOST_REGS | UFS_INFO_PWR); + /* Resume UniPro state for following error recovery */ ufs_mtk_unipro_set_pm(hba, 0); return err;