| Message ID | 20200709105826.GH2571@kadam (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] scsi: lpfc: Fix a condition in lpfc_dmp_dbg() | expand |
On 7/9/2020 3:58 AM, Dan Carpenter wrote: > These variables are unsigned so the result of the subtraction is also > unsigned and thus can't be negative. Change it to a comparison and > remove the subtraction. > > Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: I reverse the if statement in v1 > > drivers/scsi/lpfc/lpfc_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 7285b0114837..2bb2c96e7784 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba) > if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) { > temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ; > } else { > - if ((start_idx - dbg_cnt) < 0) { > + if (start_idx < dbg_cnt) { > start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx); > temp_idx = 0; > } else { Already resolved/accepted. https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=77dd7d7b3442 Thank you though. -- james
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 7285b0114837..2bb2c96e7784 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba) if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) { temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ; } else { - if ((start_idx - dbg_cnt) < 0) { + if (start_idx < dbg_cnt) { start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx); temp_idx = 0; } else {
These variables are unsigned so the result of the subtraction is also unsigned and thus can't be negative. Change it to a comparison and remove the subtraction. Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: I reverse the if statement in v1 drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)