From patchwork Thu Jul 9 12:05:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jing Xiangfeng X-Patchwork-Id: 11654321 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74D46913 for ; Thu, 9 Jul 2020 12:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E45420774 for ; Thu, 9 Jul 2020 12:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbgGIMCA (ORCPT ); Thu, 9 Jul 2020 08:02:00 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:50162 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726327AbgGIMB7 (ORCPT ); Thu, 9 Jul 2020 08:01:59 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0552E267F62BF821754F; Thu, 9 Jul 2020 20:01:58 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Thu, 9 Jul 2020 20:01:48 +0800 From: Jing Xiangfeng To: , , , , , CC: , , Subject: [PATCH v2] scsi: fcoe: add missed kfree() in an error path Date: Thu, 9 Jul 2020 20:05:46 +0800 Message-ID: <20200709120546.38453-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org fcoe_fdmi_info() misses to call kfree() in an error path. Add a label 'free_fdmi' and jump to it. Fixes: f07d46bbc9ba ("fcoe: Fix smatch warning in fcoe_fdmi_info function") Signed-off-by: Jing Xiangfeng --- drivers/scsi/fcoe/fcoe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 25dae9f0b205..a63057a03772 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -830,7 +830,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev) if (rc) { printk(KERN_INFO "fcoe: Failed to retrieve FDMI " "information from netdev.\n"); - return; + goto free_fdmi; } snprintf(fc_host_serial_number(lport->host), @@ -868,6 +868,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev) /* Enable FDMI lport states */ lport->fdmi_enabled = 1; +free_fdmi: kfree(fdmi); } else { lport->fdmi_enabled = 0;