From patchwork Mon Jul 13 07:46:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11658979 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9FD2D138C for ; Mon, 13 Jul 2020 07:47:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A4B2077D for ; Mon, 13 Jul 2020 07:47:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZOCsw2XW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729551AbgGMHrz (ORCPT ); Mon, 13 Jul 2020 03:47:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729362AbgGMHrN (ORCPT ); Mon, 13 Jul 2020 03:47:13 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C90C061794 for ; Mon, 13 Jul 2020 00:47:13 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id q5so14683179wru.6 for ; Mon, 13 Jul 2020 00:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=ZOCsw2XWfgZO4y6t3h7ZC4fRzobOluE5SfyhEp/78OJ3fXCO64cAZWdxAucxuNmb8d fQW1CEkSz0QItDOS515LTb7R10RH5gaLIez9jQ60GhEhBXW75cH8UOkkfTpZzMHQsNs/ RsCokTrSJg8XynI4R7kPRHqJgYWSukBRZIL2j5BdduQsq7UTNT/j4YCXvoRgj//aiyYU PtN6YMRIcQbXrv/HevL1q/V6DowQRP9qgKgSoXe4Va6L19t03EFjv0n4f+tzAZ92MBqk einUA1+6MQrrFUIZFRJiBhnhmdHoyPxXMqHdves3qtlqtb39O/pkYMGFAH+bp8Fw/IZK KK3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=EHB4ZMzGBO9POEWbOGOgIEm/nqB81jcSVKpusUWL8st4dRJ6gEG8FFNXwAdpQLYoS/ YCq1pqDxHyuOf/85qNu9JTFohANU9Ti9OooEdmoOSmaaDwTt0/RwklFOYBHFFxMf+5Wp E78Z5SfyeTjZs7iSFtoSn6kUnBTph3GtJJnzYxGMt36GhjeNH+/zquKsPpqnhn8xdxg3 hrnk/qdyE4wIgpJy/WQLIb1xP3i0U3E9gQv2xdcowUehOKhex/sd+ApjGz8DQ+6dn2nz cVmmL11Zy3DGEZlGIEJgkyIgD+AvAYY8oMhasFnL4LAK2V7LI1rLozdsjl3G1c3LGPxS IEOg== X-Gm-Message-State: AOAM531WkpSJCoadftkvBEndj4jzUStz/kYy539QM39vmuVodoM99XPK T6G+6kcKwpnOyrAiXkWkIOkXjA== X-Google-Smtp-Source: ABdhPJwL2BXm740AJ2eXiOSvWSy3Mw83YPcy9MYsFJYzveBILaeUUNfPsKSC84v+itS3oaSc4z3YmA== X-Received: by 2002:adf:a111:: with SMTP id o17mr77436675wro.257.1594626432329; Mon, 13 Jul 2020 00:47:12 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.6]) by smtp.gmail.com with ESMTPSA id k11sm25142488wrd.23.2020.07.13.00.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 00:47:11 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , "PMC-Sierra, Inc" Subject: [PATCH v2 23/29] scsi: aacraid: linit: Provide suggested curly braces around empty body of if() Date: Mon, 13 Jul 2020 08:46:39 +0100 Message-Id: <20200713074645.126138-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200713074645.126138-1-lee.jones@linaro.org> References: <20200713074645.126138-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’: drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] 368 | param->heads, param->sectors, num)); | ^ Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sierra, Inc" Signed-off-by: Lee Jones --- drivers/scsi/aacraid/linit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index a308e86a97f19..734dd6e67246d 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -363,9 +363,10 @@ static int aac_biosparm(struct scsi_device *sdev, struct block_device *bdev, param->cylinders = cap_to_cyls(capacity, param->heads * param->sectors); if (num < 4 && end_sec == param->sectors) { - if (param->cylinders != saved_cylinders) + if (param->cylinders != saved_cylinders) { dprintk((KERN_DEBUG "Adopting geometry: heads=%d, sectors=%d from partition table %d.\n", param->heads, param->sectors, num)); + } } else if (end_head > 0 || end_sec > 0) { dprintk((KERN_DEBUG "Strange geometry: heads=%d, sectors=%d in partition table %d.\n", end_head + 1, end_sec, num));