| Message ID | 20200715025523.34620-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ca0800a68ac7c7d75a2f93c30bc3f291450595b4 |
| Headers | show |
| Series | [-next] scsi: sd_zbc: Remove unused inline functions | expand |
On 2020/07/15 11:56, YueHaibing wrote: > They are never used, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/scsi/sd.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h > index 3a74f4b45134..27c0f4e9b1d4 100644 > --- a/drivers/scsi/sd.h > +++ b/drivers/scsi/sd.h > @@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba, > > #else /* CONFIG_BLK_DEV_ZONED */ > > -static inline int sd_zbc_init(void) > -{ > - return 0; > -} > - > static inline int sd_zbc_init_disk(struct scsi_disk *sdkp) > { > return 0; > } > > -static inline void sd_zbc_exit(void) {} > static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {} > > static inline int sd_zbc_read_zones(struct scsi_disk *sdkp, > Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
On 15/07/2020 04:56, YueHaibing wrote: > They are never used, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/scsi/sd.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h > index 3a74f4b45134..27c0f4e9b1d4 100644 > --- a/drivers/scsi/sd.h > +++ b/drivers/scsi/sd.h > @@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba, > > #else /* CONFIG_BLK_DEV_ZONED */ > > -static inline int sd_zbc_init(void) > -{ > - return 0; > -} > - > static inline int sd_zbc_init_disk(struct scsi_disk *sdkp) > { > return 0; > } > > -static inline void sd_zbc_exit(void) {} > static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {} > > static inline int sd_zbc_read_zones(struct scsi_disk *sdkp, > Woops that looks like some leftover from development. My bad. Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On Wed, 15 Jul 2020 10:55:23 +0800, YueHaibing wrote:
> They are never used, so can remove it.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: sd_zbc: Remove unused inline functions
https://git.kernel.org/mkp/scsi/c/ca0800a68ac7
diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h index 3a74f4b45134..27c0f4e9b1d4 100644 --- a/drivers/scsi/sd.h +++ b/drivers/scsi/sd.h @@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba, #else /* CONFIG_BLK_DEV_ZONED */ -static inline int sd_zbc_init(void) -{ - return 0; -} - static inline int sd_zbc_init_disk(struct scsi_disk *sdkp) { return 0; } -static inline void sd_zbc_exit(void) {} static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {} static inline int sd_zbc_read_zones(struct scsi_disk *sdkp,
They are never used, so can remove it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/scsi/sd.h | 6 ------ 1 file changed, 6 deletions(-)