| Message ID | 20200806064416.64462-1-jingxiangfeng@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() | expand |
Please ignore this patch. Thanks On 2020/8/6 14:44, Jing Xiangfeng wrote: > Fix to return error code IS_ERR() from the error handling case instead > of 0. > > Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes") > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> > --- > drivers/scsi/ufs/ti-j721e-ufs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c > index 46bb905b4d6a..eafe7c08b0c8 100644 > --- a/drivers/scsi/ufs/ti-j721e-ufs.c > +++ b/drivers/scsi/ufs/ti-j721e-ufs.c > @@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev) > /* Select MPHY refclk frequency */ > clk = devm_clk_get(dev, NULL); > if (IS_ERR(clk)) { > + ret = IS_ERR(clk); > dev_err(dev, "Cannot claim MPHY clock.\n"); > goto clk_err; > } >
diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c index 46bb905b4d6a..eafe7c08b0c8 100644 --- a/drivers/scsi/ufs/ti-j721e-ufs.c +++ b/drivers/scsi/ufs/ti-j721e-ufs.c @@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev) /* Select MPHY refclk frequency */ clk = devm_clk_get(dev, NULL); if (IS_ERR(clk)) { + ret = IS_ERR(clk); dev_err(dev, "Cannot claim MPHY clock.\n"); goto clk_err; }
Fix to return error code IS_ERR() from the error handling case instead of 0. Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes") Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/scsi/ufs/ti-j721e-ufs.c | 1 + 1 file changed, 1 insertion(+)