| Message ID | 20200810135548.28213-1-adrian.hunter@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] scsi: ufs: Fix interrupt error message for shared interrupts | expand |
> The interrupt might be shared, in which case it is not an error for the > interrupt handler to be called when the interrupt status is zero, so > remove the message print and register dump. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code") > --- > drivers/scsi/ufs/ufshcd.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index cdcf56679b41..d7522dba4dcf 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -5994,12 +5994,6 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba) > intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS); > } while (intr_status && --retries); > > - if (retval == IRQ_NONE) { Maybe if (enabled_intr_status && retval == IRQ_NONE) { ? Thanks, Avri
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index cdcf56679b41..d7522dba4dcf 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5994,12 +5994,6 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba) intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS); } while (intr_status && --retries); - if (retval == IRQ_NONE) { - dev_err(hba->dev, "%s: Unhandled interrupt 0x%08x\n", - __func__, intr_status); - ufshcd_dump_regs(hba, 0, UFSHCI_REG_SPACE_SIZE, "host_regs: "); - } - spin_unlock(hba->host->host_lock); return retval; }
The interrupt might be shared, in which case it is not an error for the interrupt handler to be called when the interrupt status is zero, so remove the message print and register dump. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code") --- drivers/scsi/ufs/ufshcd.c | 6 ------ 1 file changed, 6 deletions(-)