diff mbox series

scsi: qedf: Fix null ptr reference in qedf_stag_change_work

Message ID 20200824033436.45570-1-yebin10@huawei.com (mailing list archive)
State Mainlined
Commit f308a35f547cd7c1d8a901c12b3ac508e96df665
Headers show
Series scsi: qedf: Fix null ptr reference in qedf_stag_change_work | expand

Commit Message

yebin (H) Aug. 24, 2020, 3:34 a.m. UTC
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/scsi/qedf/qedf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Saurav Kashyap Aug. 24, 2020, 5:03 a.m. UTC | #1
Hi Bin,
Thanks for an patch.

> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-owner@vger.kernel.org>
> On Behalf Of Ye Bin
> Sent: Monday, August 24, 2020 9:05 AM
> To: QLogic-Storage-Upstream@cavium.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; linux-scsi@vger.kernel.org
> Cc: Ye Bin <yebin10@huawei.com>
> Subject: [PATCH] scsi: qedf: Fix null ptr reference in qedf_stag_change_work
> 
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 39c4bdc89937..c855ff3ad232 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3874,7 +3874,7 @@ void qedf_stag_change_work(struct work_struct
> *work)
>  	    container_of(work, struct qedf_ctx, stag_work.work);
> 
>  	if (!qedf) {
> -		QEDF_ERR(&qedf->dbg_ctx, "qedf is NULL");
> +		QEDF_ERR(NULL, "qedf is NULL");
>  		return;
>  	}
>  	QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");
> --
> 2.25.4

Acked-by: Saurav Kashyap <skashyap@marvell.com>
diff mbox series

Patch

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 39c4bdc89937..c855ff3ad232 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3874,7 +3874,7 @@  void qedf_stag_change_work(struct work_struct *work)
 	    container_of(work, struct qedf_ctx, stag_work.work);
 
 	if (!qedf) {
-		QEDF_ERR(&qedf->dbg_ctx, "qedf is NULL");
+		QEDF_ERR(NULL, "qedf is NULL");
 		return;
 	}
 	QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");