diff mbox series

scsi: isci: remove set but not used 'index'

Message ID 20200827125851.428071-1-yanaijie@huawei.com (mailing list archive)
State Accepted
Headers show
Series scsi: isci: remove set but not used 'index' | expand

Commit Message

Jason Yan Aug. 27, 2020, 12:58 p.m. UTC
This addresses the following gcc warning with "make W=1":

drivers/scsi/isci/host.c: In function ‘sci_controller_complete_io’:
drivers/scsi/isci/host.c:2674:6: warning: variable ‘index’ set but not
used [-Wunused-but-set-variable]
 2674 |  u16 index;
      |      ^~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/isci/host.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Martin K. Petersen Sept. 9, 2020, 2:09 a.m. UTC | #1
On Thu, 27 Aug 2020 20:58:51 +0800, Jason Yan wrote:

> This addresses the following gcc warning with "make W=1":
> 
> drivers/scsi/isci/host.c: In function ‘sci_controller_complete_io’:
> drivers/scsi/isci/host.c:2674:6: warning: variable ‘index’ set but not
> used [-Wunused-but-set-variable]
>  2674 |  u16 index;
>       |      ^~~~~

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: isci: Remove set but not used 'index'
      https://git.kernel.org/mkp/scsi/c/7149e0cb31c5
diff mbox series

Patch

diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c
index 7b5deae68d33..7ebfa3c8cdc7 100644
--- a/drivers/scsi/isci/host.c
+++ b/drivers/scsi/isci/host.c
@@ -2671,7 +2671,6 @@  enum sci_status sci_controller_complete_io(struct isci_host *ihost,
 					   struct isci_request *ireq)
 {
 	enum sci_status status;
-	u16 index;
 
 	switch (ihost->sm.current_state_id) {
 	case SCIC_STOPPING:
@@ -2682,7 +2681,6 @@  enum sci_status sci_controller_complete_io(struct isci_host *ihost,
 		if (status != SCI_SUCCESS)
 			return status;
 
-		index = ISCI_TAG_TCI(ireq->io_tag);
 		clear_bit(IREQ_ACTIVE, &ireq->flags);
 		return SCI_SUCCESS;
 	default: