| Message ID | 20200829075746.19166-1-tian.xianting@h3c.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: qla2xxx: Fix the return value | expand |
Xianting Tian, Thanks for the patch. > -----Original Message----- > From: Xianting Tian <tian.xianting@h3c.com> > Sent: Saturday, August 29, 2020 1:28 PM > To: Nilesh Javali <njavali@marvell.com>; GR-QLogic-Storage-Upstream <GR- > QLogic-Storage-Upstream@marvell.com>; jejb@linux.ibm.com; > martin.petersen@oracle.com > Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Xianting Tian > <tian.xianting@h3c.com> > Subject: [EXT] [PATCH] scsi: qla2xxx: Fix the return value > > External Email > > ---------------------------------------------------------------------- > A negative error code should be returned. > > Signed-off-by: Xianting Tian <tian.xianting@h3c.com> > --- > drivers/scsi/qla2xxx/qla_target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_target.c > b/drivers/scsi/qla2xxx/qla_target.c > index fbb80a043..612e001cc 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd) > "multiple abort. %p transport_state %x, t_state %x, " > "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state, > cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags); > - return EIO; > + return -EIO; > } > cmd->aborted = 1; > cmd->trc_flags |= TRC_ABORT; > -- > 2.17.1 Acked-by: Nilesh Javali <njavali@marvell.com>
On Sat, 29 Aug 2020 15:57:46 +0800, Xianting Tian wrote:
> A negative error code should be returned.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix the return value
https://git.kernel.org/mkp/scsi/c/e5f48ac42cc9
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index fbb80a043..612e001cc 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd) "multiple abort. %p transport_state %x, t_state %x, " "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state, cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags); - return EIO; + return -EIO; } cmd->aborted = 1; cmd->trc_flags |= TRC_ABORT;
A negative error code should be returned. Signed-off-by: Xianting Tian <tian.xianting@h3c.com> --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)