| Message ID | 20200911180057.14633-1-thenzl@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mpt3sas: a small correction in _base_process_reply_queue | expand |
On Fri, Sep 11, 2020 at 11:31 PM Tomas Henzl <thenzl@redhat.com> wrote: > > There is no need to compute module a simple comparision > is good enough. > > Signed-off-by: Tomas Henzl <thenzl@redhat.com> Acked-by: sreekanth reddy <sreekanth.reddy@broadcom.com> Thanks, Sreekanth > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index a67749c8f4ab..ea51fd04e3f1 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -1627,7 +1627,7 @@ _base_process_reply_queue(struct adapter_reply_queue *reply_q) > * So that FW can find enough entries to post the Reply > * Descriptors in the reply descriptor post queue. > */ > - if (!base_mod64(completed_cmds, ioc->thresh_hold)) { > + if (completed_cmds >= ioc->thresh_hold) { > if (ioc->combined_reply_queue) { > writel(reply_q->reply_post_host_index | > ((msix_index & 7) << > -- > 2.25.4 >
Tomas, > There is no need to compute module a simple comparision is good > enough. Applied to 5.10/scsi-staging, thanks!
On Fri, 11 Sep 2020 20:00:57 +0200, Tomas Henzl wrote: > There is no need to compute module a simple comparision > is good enough. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: mpt3sas: A small correction in _base_process_reply_queue https://git.kernel.org/mkp/scsi/c/3d49f7426e6c
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index a67749c8f4ab..ea51fd04e3f1 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -1627,7 +1627,7 @@ _base_process_reply_queue(struct adapter_reply_queue *reply_q) * So that FW can find enough entries to post the Reply * Descriptors in the reply descriptor post queue. */ - if (!base_mod64(completed_cmds, ioc->thresh_hold)) { + if (completed_cmds >= ioc->thresh_hold) { if (ioc->combined_reply_queue) { writel(reply_q->reply_post_host_index | ((msix_index & 7) <<
There is no need to compute module a simple comparision is good enough. Signed-off-by: Tomas Henzl <thenzl@redhat.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)