diff mbox series

scsi: aacraid: make some symbols static in aachba.c

Message ID 20200912033749.142488-1-yanaijie@huawei.com (mailing list archive)
State Accepted
Headers show
Series scsi: aacraid: make some symbols static in aachba.c | expand

Commit Message

Jason Yan Sept. 12, 2020, 3:37 a.m. UTC
This eliminates the following sparse warning:

drivers/scsi/aacraid/aachba.c:245:5: warning: symbol 'aac_convert_sgl'
was not declared. Should it be static?
drivers/scsi/aacraid/aachba.c:293:5: warning: symbol 'acbsize' was not
declared. Should it be static?
drivers/scsi/aacraid/aachba.c:324:5: warning: symbol 'aac_wwn' was not
declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/aacraid/aachba.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Martin K. Petersen Sept. 16, 2020, 1:28 a.m. UTC | #1
Jason,

> This eliminates the following sparse warning:
>
> drivers/scsi/aacraid/aachba.c:245:5: warning: symbol 'aac_convert_sgl'
> was not declared. Should it be static?
> drivers/scsi/aacraid/aachba.c:293:5: warning: symbol 'acbsize' was not
> declared. Should it be static?
> drivers/scsi/aacraid/aachba.c:324:5: warning: symbol 'aac_wwn' was not
> declared. Should it be static?

Applied to 5.10/scsi-staging, thanks!
Martin K. Petersen Sept. 22, 2020, 3:56 a.m. UTC | #2
On Sat, 12 Sep 2020 11:37:49 +0800, Jason Yan wrote:

> This eliminates the following sparse warning:
> 
> drivers/scsi/aacraid/aachba.c:245:5: warning: symbol 'aac_convert_sgl'
> was not declared. Should it be static?
> drivers/scsi/aacraid/aachba.c:293:5: warning: symbol 'acbsize' was not
> declared. Should it be static?
> drivers/scsi/aacraid/aachba.c:324:5: warning: symbol 'aac_wwn' was not
> declared. Should it be static?

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: aacraid: Make some symbols static in aachba.c
      https://git.kernel.org/mkp/scsi/c/571e15688628
diff mbox series

Patch

diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 6a44d385c745..31233f6a0274 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -242,7 +242,7 @@  int aac_commit = -1;
 int startup_timeout = 180;
 int aif_timeout = 120;
 int aac_sync_mode;  /* Only Sync. transfer - disabled */
-int aac_convert_sgl = 1;	/* convert non-conformable s/g list - enabled */
+static int aac_convert_sgl = 1;	/* convert non-conformable s/g list - enabled */
 
 module_param(aac_sync_mode, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(aac_sync_mode, "Force sync. transfer mode"
@@ -290,7 +290,7 @@  MODULE_PARM_DESC(numacb, "Request a limit to the number of adapter control"
 	" blocks (FIB) allocated. Valid values are 512 and down. Default is"
 	" to use suggestion from Firmware.");
 
-int acbsize = -1;
+static int acbsize = -1;
 module_param(acbsize, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(acbsize, "Request a specific adapter control block (FIB)"
 	" size. Valid values are 512, 2048, 4096 and 8192. Default is to use"
@@ -321,7 +321,7 @@  int aac_reset_devices;
 module_param_named(reset_devices, aac_reset_devices, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(reset_devices, "Force an adapter reset at initialization.");
 
-int aac_wwn = 1;
+static int aac_wwn = 1;
 module_param_named(wwn, aac_wwn, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(wwn, "Select a WWN type for the arrays:\n"
 	"\t0 - Disable\n"