diff mbox series

scsi: isci: make scu_link_layer_set_txcomsas_timeout() static

Message ID 20200915084000.2826741-1-yanaijie@huawei.com (mailing list archive)
State Accepted
Headers show
Series scsi: isci: make scu_link_layer_set_txcomsas_timeout() static | expand

Commit Message

Jason Yan Sept. 15, 2020, 8:40 a.m. UTC
This addresses the following sparse warning:

drivers/scsi/isci/phy.c:672:6: warning: symbol
'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be
static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/isci/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 16, 2020, 1:30 a.m. UTC | #1
Jason,

> This addresses the following sparse warning:
>
> drivers/scsi/isci/phy.c:672:6: warning: symbol
> 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be
> static?

Applied to 5.10/scsi-staging, thanks!
Martin K. Petersen Sept. 22, 2020, 3:57 a.m. UTC | #2
On Tue, 15 Sep 2020 16:40:00 +0800, Jason Yan wrote:

> This addresses the following sparse warning:
> 
> drivers/scsi/isci/phy.c:672:6: warning: symbol
> 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be
> static?

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: isci: Make scu_link_layer_set_txcomsas_timeout() static
      https://git.kernel.org/mkp/scsi/c/2494ebe1b3f7
diff mbox series

Patch

diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c
index 4cacb800b530..7041e2e3ab48 100644
--- a/drivers/scsi/isci/phy.c
+++ b/drivers/scsi/isci/phy.c
@@ -669,7 +669,7 @@  static const char *phy_event_name(u32 event_code)
 		phy_state_name(state), phy_event_name(code), code)
 
 
-void scu_link_layer_set_txcomsas_timeout(struct isci_phy *iphy, u32 timeout)
+static void scu_link_layer_set_txcomsas_timeout(struct isci_phy *iphy, u32 timeout)
 {
 	u32 val;