diff mbox series

scsi: gdth: make option_setup() static

Message ID 20200915084033.2827009-1-yanaijie@huawei.com (mailing list archive)
State Superseded
Headers show
Series scsi: gdth: make option_setup() static | expand

Commit Message

Jason Yan Sept. 15, 2020, 8:40 a.m. UTC
This addresses the following sparse warning:

drivers/scsi/gdth.c:3229:12: warning: symbol 'option_setup' was not
declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/gdth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 16, 2020, 1:35 a.m. UTC | #1
Jason,

> This addresses the following sparse warning:
>
> drivers/scsi/gdth.c:3229:12: warning: symbol 'option_setup' was not
> declared. Should it be static?

drivers/scsi/gdth.c:3229:19: error: ‘option_setup’ defined but not used [-Werror=unused-function]
 3229 | static int __init option_setup(char *str)
      |                   ^~~~~~~~~~~~
cc1: all warnings being treated as errors
diff mbox series

Patch

diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index dc0e17729acf..0519d3fa43d4 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -3226,7 +3226,7 @@  static void __init internal_setup(char *str,int *ints)
     }
 }
 
-int __init option_setup(char *str)
+static int __init option_setup(char *str)
 {
     int ints[MAXHA];
     char *cur = str;