diff mbox series

scsi: myrb: Fix inconsistent of format with argument type in myrb.c

Message ID 20200930021637.2831618-1-yebin10@huawei.com (mailing list archive)
State Accepted
Headers show
Series scsi: myrb: Fix inconsistent of format with argument type in myrb.c | expand

Commit Message

yebin (H) Sept. 30, 2020, 2:16 a.m. UTC
Fix follow warnings:
[drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 1)
	requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 2)
	requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 4)
	requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/myrb.c:2170]: (warning) %d in format string (no. 1)
	requires 'int' but the argument type is 'unsigned int'.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/scsi/myrb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Oct. 8, 2020, 3 a.m. UTC | #1
Ye,

> Fix follow warnings:
> [drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 1)
> 	requires 'int' but the argument type is 'unsigned int'.
> [drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 2)
> 	requires 'int' but the argument type is 'unsigned int'.
> [drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 4)
> 	requires 'int' but the argument type is 'unsigned int'.
> [drivers/scsi/myrb.c:2170]: (warning) %d in format string (no. 1)
> 	requires 'int' but the argument type is 'unsigned int'.

Applied to 5.10/scsi-staging, thanks!
Martin K. Petersen Oct. 13, 2020, 10:43 p.m. UTC | #2
On Wed, 30 Sep 2020 10:16:37 +0800, Ye Bin wrote:

> Fix follow warnings:
> [drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 1)
> 	requires 'int' but the argument type is 'unsigned int'.
> [drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 2)
> 	requires 'int' but the argument type is 'unsigned int'.
> [drivers/scsi/myrb.c:1052]: (warning) %d in format string (no. 4)
> 	requires 'int' but the argument type is 'unsigned int'.
> [drivers/scsi/myrb.c:2170]: (warning) %d in format string (no. 1)
> 	requires 'int' but the argument type is 'unsigned int'.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: myrb: Fix inconsistent format argument types
      https://git.kernel.org/mkp/scsi/c/fc29f04a5c6b
diff mbox series

Patch

diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index cbf1e8b091b9..df4ac3f1ca3f 100644
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -1050,7 +1050,7 @@  static int myrb_get_hba_config(struct myrb_hba *cb)
 		enquiry2->fw.turn_id = 0;
 	}
 	snprintf(cb->fw_version, sizeof(cb->fw_version),
-		"%d.%02d-%c-%02d",
+		"%u.%02u-%c-%02u",
 		enquiry2->fw.major_version,
 		enquiry2->fw.minor_version,
 		enquiry2->fw.firmware_type,
@@ -2167,7 +2167,7 @@  static ssize_t ctlr_num_show(struct device *dev,
 	struct Scsi_Host *shost = class_to_shost(dev);
 	struct myrb_hba *cb = shost_priv(shost);
 
-	return snprintf(buf, 20, "%d\n", cb->ctlr_num);
+	return snprintf(buf, 20, "%u\n", cb->ctlr_num);
 }
 static DEVICE_ATTR_RO(ctlr_num);