diff mbox series

[-next,SCSI] aic7xxx: change the error value of ahx_pci_test_register_access from postive to negative

Message ID 20201026091236.68561-1-zhangqilong3@huawei.com (mailing list archive)
State Accepted
Headers show
Series [-next,SCSI] aic7xxx: change the error value of ahx_pci_test_register_access from postive to negative | expand

Commit Message

zhangqilong Oct. 26, 2020, 9:12 a.m. UTC
A negative error code should be returned
instead of a positive one when going to
error path.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 drivers/scsi/aic7xxx/aic79xx_pci.c | 2 +-
 drivers/scsi/aic7xxx/aic7xxx_pci.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Oct. 27, 2020, 2:03 a.m. UTC | #1
Zhang,

> A negative error code should be returned instead of a positive one
> when going to error path.

Applied to 5.11/scsi-staging, thanks!
John Garry Oct. 27, 2020, 8:52 a.m. UTC | #2
On 26/10/2020 09:12, Zhang Qilong wrote:
> A negative error code should be returned
> instead of a positive one when going to
> error path.

There's many other places in this driver which still use positive error 
codes, so now inconsistent. I didn't see a good reason to change.

> 
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
>   drivers/scsi/aic7xxx/aic79xx_pci.c | 2 +-
>   drivers/scsi/aic7xxx/aic7xxx_pci.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/aic7xxx/aic79xx_pci.c b/drivers/scsi/aic7xxx/aic79xx_pci.c
> index 8397ae93f7dd..0edce0ebd944 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_pci.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_pci.c
> @@ -419,7 +419,7 @@ ahd_pci_test_register_access(struct ahd_softc *ahd)
>   	int	 error;
>   	uint8_t	 hcntrl;
>   
> -	error = EIO;
> +	error = -EIO;
>   
>   	/*
>   	 * Enable PCI error interrupt status, but suppress NMIs
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> index 656f680c7802..cbeca694e883 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> @@ -1168,7 +1168,7 @@ ahc_pci_test_register_access(struct ahc_softc *ahc)
>   	uint32_t cmd;
>   	uint8_t	 hcntrl;
>   
> -	error = EIO;
> +	error = -EIO;
>   
>   	/*
>   	 * Enable PCI error interrupt status, but suppress NMIs
>
diff mbox series

Patch

diff --git a/drivers/scsi/aic7xxx/aic79xx_pci.c b/drivers/scsi/aic7xxx/aic79xx_pci.c
index 8397ae93f7dd..0edce0ebd944 100644
--- a/drivers/scsi/aic7xxx/aic79xx_pci.c
+++ b/drivers/scsi/aic7xxx/aic79xx_pci.c
@@ -419,7 +419,7 @@  ahd_pci_test_register_access(struct ahd_softc *ahd)
 	int	 error;
 	uint8_t	 hcntrl;
 
-	error = EIO;
+	error = -EIO;
 
 	/*
 	 * Enable PCI error interrupt status, but suppress NMIs
diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c b/drivers/scsi/aic7xxx/aic7xxx_pci.c
index 656f680c7802..cbeca694e883 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
@@ -1168,7 +1168,7 @@  ahc_pci_test_register_access(struct ahc_softc *ahc)
 	uint32_t cmd;
 	uint8_t	 hcntrl;
 
-	error = EIO;
+	error = -EIO;
 
 	/*
 	 * Enable PCI error interrupt status, but suppress NMIs