diff mbox series

[22/34] scsi_debug: do not set COMMAND_COMPLETE

Message ID 20201202115249.37690-23-hare@suse.de (mailing list archive)
State Superseded
Headers show
Series SCSI result handling cleanup, part 1 | expand

Commit Message

Hannes Reinecke Dec. 2, 2020, 11:52 a.m. UTC 
COMMAND_COMPLETE is defined as '0', so setting it is quite pointless.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/scsi_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Dec. 2, 2020, 4:33 p.m. UTC | #1 
On Wed, Dec 02, 2020 at 12:52:37PM +0100, Hannes Reinecke wrote:
> COMMAND_COMPLETE is defined as '0', so setting it is quite pointless.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Douglas Gilbert Dec. 2, 2020, 4:50 p.m. UTC | #2 
On 2020-12-02 6:52 a.m., Hannes Reinecke wrote:
> COMMAND_COMPLETE is defined as '0', so setting it is quite pointless.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>

Thanks.

> ---
>   drivers/scsi/scsi_debug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 24c0f7ec0351..93048f13a4e3 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -853,7 +853,7 @@ static const int illegal_condition_result =
>   	(DRIVER_SENSE << 24) | (DID_ABORT << 16) | SAM_STAT_CHECK_CONDITION;
>   
>   static const int device_qfull_result =
> -	(DID_OK << 16) | (COMMAND_COMPLETE << 8) | SAM_STAT_TASK_SET_FULL;
> +	(DID_OK << 16) | SAM_STAT_TASK_SET_FULL;
>   
>   static const int condition_met_result = SAM_STAT_CONDITION_MET;
>   
>
diff mbox series

Patch

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 24c0f7ec0351..93048f13a4e3 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -853,7 +853,7 @@  static const int illegal_condition_result =
 	(DRIVER_SENSE << 24) | (DID_ABORT << 16) | SAM_STAT_CHECK_CONDITION;
 
 static const int device_qfull_result =
-	(DID_OK << 16) | (COMMAND_COMPLETE << 8) | SAM_STAT_TASK_SET_FULL;
+	(DID_OK << 16) | SAM_STAT_TASK_SET_FULL;
 
 static const int condition_met_result = SAM_STAT_CONDITION_MET;