| Message ID | 20201202115249.37690-29-hare@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | SCSI result handling cleanup, part 1 | expand |
On Wed, Dec 02, 2020 at 12:52:43PM +0100, Hannes Reinecke wrote: > The message byte setting always devolves to COMMAND_COMPLETE, so > we can drop setting the message byte in the SCSI result. > > Signed-off-by: Hannes Reinecke <hare@suse.de> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c index f6f663f554a7..c8ae81d64b06 100644 --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c @@ -921,7 +921,6 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent, */ cmd->result = ((DRIVER_SENSE << 24) | (DID_OK << 16) | - (COMMAND_COMPLETE << 8) | (SAM_STAT_CHECK_CONDITION << 0)); ent->flags &= ~ESP_CMD_FLAG_AUTOSENSE; @@ -1869,7 +1868,6 @@ static int esp_process_event(struct esp *esp) esp_autosense(esp, ent); } else { cmd->result = ent->status; - set_msg_byte(cmd, ent->message); esp_cmd_is_done(esp, ent, cmd, DID_OK); } } else if (ent->message == DISCONNECT) {
The message byte setting always devolves to COMMAND_COMPLETE, so we can drop setting the message byte in the SCSI result. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/esp_scsi.c | 2 -- 1 file changed, 2 deletions(-)