| Message ID | 20201217105144.8055-1-njavali@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | qedi: Correct max length of CHAP secret | expand |
On 12/17/20 2:51 AM, Nilesh Javali wrote: > The CHAP secret displayed garbage characters causing iSCSI login > authentication failure. Correct the CHAP password max length. > > Signed-off-by: Nilesh Javali <njavali@marvell.com> > --- > drivers/scsi/qedi/qedi_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c > index f5fc7f518f8a..47ad64b06623 100644 > --- a/drivers/scsi/qedi/qedi_main.c > +++ b/drivers/scsi/qedi/qedi_main.c > @@ -2245,7 +2245,7 @@ qedi_show_boot_tgt_info(struct qedi_ctx *qedi, int type, > chap_name); > break; > case ISCSI_BOOT_TGT_CHAP_SECRET: > - rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_NAME_MAX_LEN, > + rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_PWD_MAX_LEN, > chap_secret); > break; > case ISCSI_BOOT_TGT_REV_CHAP_NAME: > @@ -2253,7 +2253,7 @@ qedi_show_boot_tgt_info(struct qedi_ctx *qedi, int type, > mchap_name); > break; > case ISCSI_BOOT_TGT_REV_CHAP_SECRET: > - rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_NAME_MAX_LEN, > + rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_PWD_MAX_LEN, > mchap_secret); > break; > case ISCSI_BOOT_TGT_FLAGS: > Reviewed-by: Lee Duncan <lduncan@suse.com>
On Thu, 17 Dec 2020 02:51:44 -0800, Nilesh Javali wrote: > The CHAP secret displayed garbage characters causing iSCSI login > authentication failure. Correct the CHAP password max length. Applied to 5.11/scsi-fixes, thanks! [1/1] qedi: Correct max length of CHAP secret https://git.kernel.org/mkp/scsi/c/d50c7986fbf0
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index f5fc7f518f8a..47ad64b06623 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -2245,7 +2245,7 @@ qedi_show_boot_tgt_info(struct qedi_ctx *qedi, int type, chap_name); break; case ISCSI_BOOT_TGT_CHAP_SECRET: - rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_NAME_MAX_LEN, + rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_PWD_MAX_LEN, chap_secret); break; case ISCSI_BOOT_TGT_REV_CHAP_NAME: @@ -2253,7 +2253,7 @@ qedi_show_boot_tgt_info(struct qedi_ctx *qedi, int type, mchap_name); break; case ISCSI_BOOT_TGT_REV_CHAP_SECRET: - rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_NAME_MAX_LEN, + rc = sprintf(buf, "%.*s\n", NVM_ISCSI_CFG_CHAP_PWD_MAX_LEN, mchap_secret); break; case ISCSI_BOOT_TGT_FLAGS:
The CHAP secret displayed garbage characters causing iSCSI login authentication failure. Correct the CHAP password max length. Signed-off-by: Nilesh Javali <njavali@marvell.com> --- drivers/scsi/qedi/qedi_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)