diff mbox series

[32/35] storvsc: Return DID_ERROR for invalid commands

Message ID	20210113090500.129644-33-hare@suse.de (mailing list archive)
State	Accepted
Headers	show Return-Path: <linux-scsi-owner@kernel.org> From: Hannes Reinecke <hare@suse.de> To: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Christoph Hellwig <hch@lst.de>, James Bottomley <james.bottomley@hansenpartnership.com>, linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCH 32/35] storvsc: Return DID_ERROR for invalid commands Date: Wed, 13 Jan 2021 10:04:57 +0100 Message-Id: <20210113090500.129644-33-hare@suse.de> In-Reply-To: <20210113090500.129644-1-hare@suse.de> References: <20210113090500.129644-1-hare@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	SCSI result handling cleanup, part 1 \| expand [PATCHv4,00/35,PATCHv3,00/35] SCSI result handling cleanup, part 1 [01/35] scsi: drop gdth driver [02/35] 3w-xxxx: Whitespace cleanup [03/35] 3w-9xxx: Whitespace cleanup [04/35] 3w-sas: Whitespace cleanup [05/35] atp870u: Whitespace cleanup [06/35] aic7xxx,aic79xx: Whitespace cleanup [07/35] aic7xxx,aic79xx: kill pointless forward declarations [08/35] aic7xxx,aic79xxx: remove driver-defined SAM status definitions [09/35] bfa: drop driver-defined SCSI status codes [10/35] acornscsi: use standard defines [11/35] nsp32: fixup status handling [12/35] dc395: drop private SAM status code definitions [13/35] qla4xxx: use standard SAM status definitions [14/35] zfcp: do not set COMMAND_COMPLETE [15/35] aacraid: avoid setting message byte on completion [16/35] hpsa: do not set COMMAND_COMPLETE [17/35] stex: do not set COMMAND_COMPLETE [18/35] nsp_cs: drop internal SCSI message definition [19/35] aic7xxx,aic79xx: drop internal SCSI message definition [20/35] dc395x: drop internal SCSI message definitions [21/35] initio: drop internal SCSI message definition [22/35] scsi_debug: do not set COMMAND_COMPLETE [23/35] ufshcd: do not set COMMAND_COMPLETE [24/35] atp870u: use standard definitions [25/35] mac53c94: Do not set invalid command result [26/35] dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message [27/35] scsi: add 'set_status_byte()' accessor [28/35] esp_scsi: use host byte as last argument to esp_cmd_is_done() [29/35] esp_scsi: do not set SCSI message byte [30/35] wd33c93: use SCSI status [31/35] ips: use correct command completion on error [32/35] storvsc: Return DID_ERROR for invalid commands [33/35] qla2xxx: fc_remote_port_chkready() returns a SCSI result value [34/35] advansys: kill driver_defined status byte accessors [35/35] ncr53c8xx: Use SAM status values

Commit Message

Hannes Reinecke Jan. 13, 2021, 9:04 a.m. UTC

ILLEGAL_COMMAND is a sense code, not a driver byte.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/storvsc_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index f0fa42f9374c..6bc5453cea8a 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1671,7 +1671,7 @@  static bool storvsc_scsi_cmd_ok(struct scsi_cmnd *scmnd)
 	 * this. So, don't send it.
 	 */
 	case SET_WINDOW:
-		scmnd->result = ILLEGAL_REQUEST << 16;
+		scmnd->result = DID_ERROR << 16;
 		allowed = false;
 		break;
 	default: