| Message ID | 20210128055658.530133-1-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | sd: warn if unsupported ZBC device is probed | expand |
Damien, > In sd_probe(), print a warning if CONFIG_BLK_DEV_ZONED is disabled and > a TYPE_ZBC device is found. While at it, use IS_ENABLED() to test if > CONFIG_BLK_DEV_ZONED is enabled instead using of a #ifdef. Applied to 5.12/scsi-staging, thanks!
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index a3d2d4bc4a3d..6e41ecbf4399 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3379,10 +3379,12 @@ static int sd_probe(struct device *dev) sdp->type != TYPE_RBC) goto out; -#ifndef CONFIG_BLK_DEV_ZONED - if (sdp->type == TYPE_ZBC) + if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED) && sdp->type == TYPE_ZBC) { + sdev_printk(KERN_WARNING, sdp, + "Unsupported ZBC host-managed device.\n"); goto out; -#endif + } + SCSI_LOG_HLQUEUE(3, sdev_printk(KERN_INFO, sdp, "sd_probe\n"));
In sd_probe(), print a warning if CONFIG_BLK_DEV_ZONED is disabled and a TYPE_ZBC device is found. While at it, use IS_ENABLED() to test if CONFIG_BLK_DEV_ZONED is enabled instead using of a #ifdef. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- drivers/scsi/sd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)