diff mbox series

[11/22] lpfc: Fix status returned in lpfc_els_retry() error exit path

Message ID 20210211234443.3107-12-jsmart2021@gmail.com (mailing list archive)
State Superseded
Headers show
Series lpfc: Update lpfc to revision | expand

Commit Message

James Smart Feb. 11, 2021, 11:44 p.m. UTC
An unlikely error exit path from lpfc_els_retry() returns incorrect
status to a caller, erroneously indicating that a retry has been
successfully issued or scheduled.

Change error exit path to indicate no retry.

Co-developed-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
 drivers/scsi/lpfc/lpfc_els.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index ee362e6c0d62..a359d0ddd6e8 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -3822,7 +3822,7 @@  lpfc_els_retry(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 		did = irsp->un.elsreq64.remoteID;
 		ndlp = lpfc_findnode_did(vport, did);
 		if (!ndlp && (cmd != ELS_CMD_PLOGI))
-			return 1;
+			return 0;
 	lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_CMD,