diff mbox series

scsi: snic: Convert to DEFINE_SHOW_ATTRIBUTE

Message ID 20210331065326.18804-1-dingsenjie@163.com (mailing list archive)
State Accepted
Headers show
Series scsi: snic: Convert to DEFINE_SHOW_ATTRIBUTE | expand

Commit Message

dingsenjie@163.com March 31, 2021, 6:53 a.m. UTC 
From: dingsenjie <dingsenjie@yulong.com>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
 drivers/scsi/snic/snic_debugfs.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

Comments

Martin K. Petersen April 16, 2021, 2:51 a.m. UTC | #1 
On Wed, 31 Mar 2021 14:53:25 +0800, dingsenjie@163.com wrote:

> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: snic: Convert to DEFINE_SHOW_ATTRIBUTE
      https://git.kernel.org/mkp/scsi/c/54300bfd738b
diff mbox series

Patch

diff --git a/drivers/scsi/snic/snic_debugfs.c b/drivers/scsi/snic/snic_debugfs.c
index 4471c4c..3aeee85 100644
--- a/drivers/scsi/snic/snic_debugfs.c
+++ b/drivers/scsi/snic/snic_debugfs.c
@@ -334,25 +334,7 @@  void snic_debugfs_init(void)
 	return 0;
 }
 
-/*
- * snic_stats_open - Open the stats file for specific host
- *
- * Description:
- * This routine opens a debugfs file stats of specific host
- */
-static int
-snic_stats_open(struct inode *inode, struct file *filp)
-{
-	return single_open(filp, snic_stats_show, inode->i_private);
-}
-
-static const struct file_operations snic_stats_fops = {
-	.owner	= THIS_MODULE,
-	.open	= snic_stats_open,
-	.read	= seq_read,
-	.llseek = seq_lseek,
-	.release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(snic_stats);
 
 static const struct file_operations snic_reset_stats_fops = {
 	.owner = THIS_MODULE,