diff mbox series

[v3,8/8] core: Remove scsi_get_lba()

Message ID 20210513223757.3938-9-bvanassche@acm.org (mailing list archive)
State Superseded
Headers show
Series Rename scsi_get_lba() into scsi_get_sector() | expand

Commit Message

Bart Van Assche May 13, 2021, 10:37 p.m. UTC 
Remove scsi_get_lba() since all callers have been converted to
scsi_get_sector().

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 include/scsi/scsi_cmnd.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Damien Le Moal May 14, 2021, 2:06 a.m. UTC | #1 
On 2021/05/14 7:38, Bart Van Assche wrote:
> Remove scsi_get_lba() since all callers have been converted to
> scsi_get_sector().
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  include/scsi/scsi_cmnd.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
> index 7f55faa70301..77a0916c8769 100644
> --- a/include/scsi/scsi_cmnd.h
> +++ b/include/scsi/scsi_cmnd.h
> @@ -284,11 +284,6 @@ static inline unsigned char scsi_get_prot_type(struct scsi_cmnd *scmd)
>  	return scmd->prot_type;
>  }
>  
> -static inline sector_t scsi_get_lba(struct scsi_cmnd *scmd)
> -{
> -	return blk_rq_pos(scmd->request);
> -}
> -
>  static inline sector_t scsi_get_sector(struct scsi_cmnd *scmd)
>  {
>  	return blk_rq_pos(scmd->request);
> 

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
diff mbox series

Patch

diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
index 7f55faa70301..77a0916c8769 100644
--- a/include/scsi/scsi_cmnd.h
+++ b/include/scsi/scsi_cmnd.h
@@ -284,11 +284,6 @@  static inline unsigned char scsi_get_prot_type(struct scsi_cmnd *scmd)
 	return scmd->prot_type;
 }
 
-static inline sector_t scsi_get_lba(struct scsi_cmnd *scmd)
-{
-	return blk_rq_pos(scmd->request);
-}
-
 static inline sector_t scsi_get_sector(struct scsi_cmnd *scmd)
 {
 	return blk_rq_pos(scmd->request);