| Message ID | 20210531122444.116655-1-dwagner@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | qla2xxx: Log PCI address in qla_nvme_unregister_remote_port() | expand |
On 5/31/21 7:24 AM, Daniel Wagner wrote: > Pass in fcport->vha to ql_log() in order to add the PCI address to the > log. > > Currently NULL is passed in which gives this confusing log entry: > >> qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7 > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/scsi/qla2xxx/qla_nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c > index 0cacb667a88b..e119f8b24e33 100644 > --- a/drivers/scsi/qla2xxx/qla_nvme.c > +++ b/drivers/scsi/qla2xxx/qla_nvme.c > @@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport) > if (!IS_ENABLED(CONFIG_NVME_FC)) > return; > > - ql_log(ql_log_warn, NULL, 0x2112, > + ql_log(ql_log_warn, fcport->vha, 0x2112, > "%s: unregister remoteport on %p %8phN\n", > __func__, fcport, fcport->port_name); > > Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Daniel, > Pass in fcport->vha to ql_log() in order to add the PCI address to the > log. Applied to 5.14/scsi-staging, thanks!
On Mon, 31 May 2021 14:24:44 +0200, Daniel Wagner wrote: > Pass in fcport->vha to ql_log() in order to add the PCI address to the > log. > > Currently NULL is passed in which gives this confusing log entry: > > > qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7 Applied to 5.14/scsi-queue, thanks! [1/1] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port() https://git.kernel.org/mkp/scsi/c/27c707b14659
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 0cacb667a88b..e119f8b24e33 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport) if (!IS_ENABLED(CONFIG_NVME_FC)) return; - ql_log(ql_log_warn, NULL, 0x2112, + ql_log(ql_log_warn, fcport->vha, 0x2112, "%s: unregister remoteport on %p %8phN\n", __func__, fcport, fcport->port_name);