From patchwork Mon Jul 12 09:50:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avri Altman X-Patchwork-Id: 12370643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D3DC07E99 for ; Mon, 12 Jul 2021 09:51:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2C6961026 for ; Mon, 12 Jul 2021 09:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238022AbhGLJyO (ORCPT ); Mon, 12 Jul 2021 05:54:14 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:32759 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236948AbhGLJyM (ORCPT ); Mon, 12 Jul 2021 05:54:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1626083486; x=1657619486; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bB7MvasJZ9DncuscKSgJFhICGBgcOVqFqTXKWZPhUQU=; b=OJRLwhzwuUvMtWtMvoso6XL6/voCkmT3n58gp4un7/wqmodwE5izJ3fq KarvIp0bF7c6xNmm7PMBhwI7LT0KwYCN+so7zlsyxQq0hfTF5r57oHbci RMGu2dW2btoCWEPRxAMJgx731gMnMZq+RaCz/B3Ae9/m/7Cv/8moSQJ3J rs7d6OUN0FKDPl8GDoSdGJebUGhulk50mLr77KnPe74bEuAd58aGrKhpo d5+5PgFhzhBgJUQivYH97jFSlg3oZYOOzCubbLDkbuC5PhBxbN1PjR8MV I9GSklJ1e04VJVrvUb2NLL/2sCn2nM1orzhcqa+0PZvB3RlbgAoFgiNmS A==; IronPort-SDR: 6+bN4A1CiWHehEK7adS7qYnM9bEQLttkYKEPBSrnnR5x60xS6/IcKImX0DwV/RYm6Jn6ytJu68 tspQp45uGV66o2swNiyxa/uIRIaO8SM6bUS7kpY+CAWYB7l9gvVyJLMPTaZz9FoN9tl87OyrIU MCDwibKhLC1EF/FFqkO8YVSwCx55GIW5yOL56ifkx66shbFDSINY6ZKEzTCnCrEjrKQKmkslw0 KJo5g2eVjXNBmZq2JWyt5CNAR+1PEADStOPf5EGUd6YIcjRm4+sKu5CmsMzT2wt6JENfO9HImA U0s= X-IronPort-AV: E=Sophos;i="5.84,232,1620662400"; d="scan'208";a="174920170" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 12 Jul 2021 17:51:25 +0800 IronPort-SDR: W4PjXmAUalJoJeH2f4KSsperFqvzHan4BsFwmwnmZw46LrnEITTPFq0Q2rZenFUweLkGbLdFTO rggO+LzRq/XelRIY5qp5QhkJtP4FDPuLzkez5ll92VHT+hTPMFGXQNiGKWT3A9i6pEFbIkb+br yzh9kwjFt2fwQ2hG3Tqs7nfMu6GSRp/V/g6DRIKWKQK8xa3QUvwMxSnXz4+aCk3iVQGVJXcI7Z ocz3hHTdVbWj6d7vK0vY8OTZMEGXzHo1N7LrT83Jp9WTeX6ysi3hxpQNxWUFQfjbEkP0gkU63D nC25OG8Mvs7qjH8dlcmA6fl4 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2021 02:29:30 -0700 IronPort-SDR: 1nhFrDFpTgEmecWHRaPtghg0cgmtVG1HnZSyD/+Phx+pmTpO+8ws04ZtlrJUf3zJ77qqDY7BHB bLj3uKjLyrh53Bq7FrNP0YATO1qk1ZcIBFGer+0HSN4eBxrhJrzU9sW0pJX0esXcLVw37HwmqH nFydc8+Ur3wdypooAElFlo1Jcfnx6i4L+4pg2pLRY10oaNJ7z+ONgPt0G1ZYiln67PGMqjHx4+ M/vGiKTRYt8E0rB4IQkPTSyxwjANilc/ZyIUf8EJIcpHQ4FutFvNE0x7c44xbK5sEN94rwBYJv BNw= WDCIronportException: Internal Received: from bxygm33.sdcorp.global.sandisk.com ([10.0.231.247]) by uls-op-cesaip02.wdc.com with ESMTP; 12 Jul 2021 02:51:19 -0700 From: Avri Altman To: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, Bart Van Assche , yongmyung lee , Daejun Park , alim.akhtar@samsung.com, asutoshd@codeaurora.org, Zang Leigang , Avi Shchislowski , Bean Huo , cang@codeaurora.org, stanley.chu@mediatek.com, Avri Altman Subject: [PATCH v12 02/12] scsi: ufshpb: Add host control mode support to rsp_upiu Date: Mon, 12 Jul 2021 12:50:29 +0300 Message-Id: <20210712095039.8093-3-avri.altman@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210712095039.8093-1-avri.altman@wdc.com> References: <20210712095039.8093-1-avri.altman@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org In device control mode, the device may recommend the host to either activate or inactivate a region, and the host should follow. Meaning those are not actually recommendations, but more of instructions. On the contrary, in host control mode, the recommendation protocol is slightly changed: a) The device may only recommend the host to update a subregion of an already-active region. And, b) The device may *not* recommend to inactivate a region. Furthermore, in host control mode, the host may choose not to follow any of the device's recommendations. However, in case of a recommendation to update an active and clean subregion, it is better to follow those recommendation because otherwise the host has no other way to know that some internal relocation took place. Signed-off-by: Avri Altman Reviewed-by: Daejun Park --- drivers/scsi/ufs/ufshpb.c | 34 +++++++++++++++++++++++++++++++++- drivers/scsi/ufs/ufshpb.h | 2 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index c6fa9cee683a..0ac0a4ec1e1f 100644 --- a/drivers/scsi/ufs/ufshpb.c +++ b/drivers/scsi/ufs/ufshpb.c @@ -167,6 +167,8 @@ static void ufshpb_set_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx, else set_bit_len = cnt; + set_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); + if (rgn->rgn_state != HPB_RGN_INACTIVE && srgn->srgn_state == HPB_SRGN_VALID) bitmap_set(srgn->mctx->ppn_dirty, srgn_offset, set_bit_len); @@ -236,6 +238,11 @@ static bool ufshpb_test_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx, return false; } +static inline bool is_rgn_dirty(struct ufshpb_region *rgn) +{ + return test_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); +} + static int ufshpb_fill_ppn_from_page(struct ufshpb_lu *hpb, struct ufshpb_map_ctx *mctx, int pos, int len, __be64 *ppn_buf) @@ -713,6 +720,7 @@ static void ufshpb_put_map_req(struct ufshpb_lu *hpb, static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb, struct ufshpb_subregion *srgn) { + struct ufshpb_region *rgn; u32 num_entries = hpb->entries_per_srgn; if (!srgn->mctx) { @@ -726,6 +734,10 @@ static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb, num_entries = hpb->last_srgn_entries; bitmap_zero(srgn->mctx->ppn_dirty, num_entries); + + rgn = hpb->rgn_tbl + srgn->rgn_idx; + clear_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); + return 0; } @@ -1238,6 +1250,18 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, srgn_i = be16_to_cpu(rsp_field->hpb_active_field[i].active_srgn); + rgn = hpb->rgn_tbl + rgn_i; + if (hpb->is_hcm && + (rgn->rgn_state != HPB_RGN_ACTIVE || is_rgn_dirty(rgn))) { + /* + * in host control mode, subregion activation + * recommendations are only allowed to active regions. + * Also, ignore recommendations for dirty regions - the + * host will make decisions concerning those by himself + */ + continue; + } + dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "activate(%d) region %d - %d\n", i, rgn_i, srgn_i); @@ -1245,7 +1269,6 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, ufshpb_update_active_info(hpb, rgn_i, srgn_i); spin_unlock(&hpb->rsp_list_lock); - rgn = hpb->rgn_tbl + rgn_i; srgn = rgn->srgn_tbl + srgn_i; /* blocking HPB_READ */ @@ -1256,6 +1279,14 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, hpb->stats.rb_active_cnt++; } + if (hpb->is_hcm) { + /* + * in host control mode the device is not allowed to inactivate + * regions + */ + goto out; + } + for (i = 0; i < rsp_field->inactive_rgn_cnt; i++) { rgn_i = be16_to_cpu(rsp_field->hpb_inactive_field[i]); dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, @@ -1280,6 +1311,7 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, hpb->stats.rb_inactive_cnt++; } +out: dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "Noti: #ACT %u #INACT %u\n", rsp_field->active_rgn_cnt, rsp_field->inactive_rgn_cnt); diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index dc168ba08a09..9ab502f82835 100644 --- a/drivers/scsi/ufs/ufshpb.h +++ b/drivers/scsi/ufs/ufshpb.h @@ -121,6 +121,8 @@ struct ufshpb_region { /* below information is used by lru */ struct list_head list_lru_rgn; + unsigned long rgn_flags; +#define RGN_FLAG_DIRTY 0 }; #define for_each_sub_region(rgn, i, srgn) \