Message ID | 20210722033439.26550-11-bvanassche@acm.org (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | UFS patches for kernel v5.15 | expand |
On Wed, 2021-07-21 at 20:34 -0700, Bart Van Assche wrote: > Inline ufshcd_outstanding_req_clear() since it only has one caller > and > > since its body is only one line long. > > > > Reviewed-by: Avri Altman <avri.altman@wdc.com> > > Cc: Adrian Hunter <adrian.hunter@intel.com> > > Cc: Stanley Chu <stanley.chu@mediatek.com> > > Cc: Can Guo <cang@codeaurora.org> > > Cc: Asutosh Das <asutoshd@codeaurora.org> > > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Bean Huo <beanhuo@micron.com>
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index d1c3a984d803..4c6d832f5e81 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -742,16 +742,6 @@ static inline void ufshcd_utmrl_clear(struct ufs_hba *hba, u32 pos) ufshcd_writel(hba, ~(1 << pos), REG_UTP_TASK_REQ_LIST_CLEAR); } -/** - * ufshcd_outstanding_req_clear - Clear a bit in outstanding request field - * @hba: per adapter instance - * @tag: position of the bit to be cleared - */ -static inline void ufshcd_outstanding_req_clear(struct ufs_hba *hba, int tag) -{ - clear_bit(tag, &hba->outstanding_reqs); -} - /** * ufshcd_get_lists_status - Check UCRDY, UTRLRDY and UTMRLRDY * @reg: Register value of host controller status @@ -2899,7 +2889,7 @@ static int ufshcd_wait_for_dev_cmd(struct ufs_hba *hba, * we also need to clear the outstanding_request * field in hba */ - ufshcd_outstanding_req_clear(hba, lrbp->task_tag); + clear_bit(lrbp->task_tag, &hba->outstanding_reqs); } return err;