diff mbox series

scsi: qedi: add missing curly braces

Message ID 20210812063305.GA9100@kili (mailing list archive)
State Not Applicable
Headers show
Series scsi: qedi: add missing curly braces | expand

Commit Message

Dan Carpenter Aug. 12, 2021, 6:33 a.m. UTC 
This if statement has missing curly braces so it will always report an
error even when the call to ->offload_conn() succeeded.

Fixes: 072ae05a044f ("scsi: qedi: Add support for fastpath doorbell recovery")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/qedi/qedi_iscsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen Aug. 16, 2021, 5:19 p.m. UTC | #1 
Hi Dan!

> This if statement has missing curly braces so it will always report an
> error even when the call to ->offload_conn() succeeded.

Already fixed this up in 9757f8af0442.

Thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
index 8ac8aabc1ef6..c5260429c637 100644
--- a/drivers/scsi/qedi/qedi_iscsi.c
+++ b/drivers/scsi/qedi/qedi_iscsi.c
@@ -599,7 +599,7 @@  static int qedi_iscsi_offload_conn(struct qedi_endpoint *qedi_ep)
 	}
 
 	rval = qedi_ops->offload_conn(qedi->cdev, qedi_ep->handle, conn_info);
-	if (rval)
+	if (rval) {
 		/* delete doorbell from doorbell recovery mechanism */
 		rval = qedi_ops->common->db_recovery_del(qedi->cdev,
 							 qedi_ep->p_doorbell,
@@ -607,6 +607,7 @@  static int qedi_iscsi_offload_conn(struct qedi_endpoint *qedi_ep)
 
 		QEDI_ERR(&qedi->dbg_ctx, "offload_conn returned %d, ep=%p\n",
 			 rval, qedi_ep);
+	}
 
 	kfree(conn_info);
 	return rval;