diff mbox series

[v2] scsi: ufs: ufshpb: Remove unused parameters

Message ID 20210901004620.29929-1-cw9316.lee@samsung.com (mailing list archive)
State Superseded
Headers show
Series [v2] scsi: ufs: ufshpb: Remove unused parameters | expand

Commit Message

Chanwoo Lee Sept. 1, 2021, 12:46 a.m. UTC 
From: ChanWoo Lee <cw9316.lee@samsung.com>

The following parameters are not used in the function.
So, remove unused parameters.

*func(): ufshpb_set_hpb_read_to_upiu
 -> struct ufshpb_lu *hpb
 -> u32 lpn

Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

---
v1->v2:
 * edit description.
---
 drivers/scsi/ufs/ufshpb.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Daejun Park Sept. 1, 2021, 2:02 a.m. UTC | #1 
Hi ChanWoo Lee,

>From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
>The following parameters are not used in the function.
>So, remove unused parameters.
> 
>*func(): ufshpb_set_hpb_read_to_upiu
> -> struct ufshpb_lu *hpb
> -> u32 lpn
> 
>Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

Please add Bart's tag above your signed-off tag.

Reviewed-by: Daejun Park <daejun7.park@samsung.com>
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 02fb51ae8b25..589af5f6b940 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -333,9 +333,8 @@  ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
 }
 
 static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
-			    struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
-			    u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+			    __be64 ppn, u8 transfer_len, int read_id)
 {
 	unsigned char *cdb = lrbp->cmd->cmnd;
 	__be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@  int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 		}
 	}
 
-	ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
-				    read_id);
+	ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);
 
 	hpb->stats.hit_cnt++;
 	return 0;