diff mbox series

[v3] scsi: ufs: ufshpb: Remove unused parameters

Message ID 20210901025617.31174-1-cw9316.lee@samsung.com (mailing list archive)
State Accepted
Headers show
Series [v3] scsi: ufs: ufshpb: Remove unused parameters | expand

Commit Message

Chanwoo Lee Sept. 1, 2021, 2:56 a.m. UTC 
From: ChanWoo Lee <cw9316.lee@samsung.com>

The following parameters are not used in the function.
So, remove unused parameters.

*func(): ufshpb_set_hpb_read_to_upiu
 -> struct ufshpb_lu *hpb
 -> u32 lpn

Reviewed-by: Daejun Park <daejun7.park@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

---
v2->v3:
 * Add tag information.
v1->v2:
 * edit description.
---
 drivers/scsi/ufs/ufshpb.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Martin K. Petersen Sept. 14, 2021, 3:43 a.m. UTC | #1 
On Wed, 1 Sep 2021 11:56:17 +0900, Chanwoo Lee wrote:

> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> The following parameters are not used in the function.
> So, remove unused parameters.
> 
> *func(): ufshpb_set_hpb_read_to_upiu
>  -> struct ufshpb_lu *hpb
>  -> u32 lpn
> 
> [...]

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: ufs: ufshpb: Remove unused parameters
      https://git.kernel.org/mkp/scsi/c/65ef27f7798b
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 02fb51ae8b25..589af5f6b940 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -333,9 +333,8 @@  ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
 }
 
 static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
-			    struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
-			    u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+			    __be64 ppn, u8 transfer_len, int read_id)
 {
 	unsigned char *cdb = lrbp->cmd->cmnd;
 	__be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@  int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 		}
 	}
 
-	ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
-				    read_id);
+	ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);
 
 	hpb->stats.hit_cnt++;
 	return 0;